[PR PATCH] go: update to 1.16

[PR PATCH] go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 2084 bytes --]

There is a new pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages go
https://github.com/void-linux/void-packages/pull/28825

go: update to 1.16
<!-- Mark items with [x] where applicable -->
Tested on x86_64-glibc.

According to the release notes, this version no more supports x87 on the 386 arch, but only SSE2 and softfloat. I think SSE2 was the default even in older releases.
Since Void's i686 port must not require SSE2, we should both export `GO386=softfloat` when building the compiler (if needed) and set it as the default for the package. I don't know how to do it however. Setting it in `do_build()` makes the build fail.

Also, `GO111MODULE` now defaults to `on` instead of `auto`. Should we provide an INSTALL.msg?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28825.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-28825.patch --]
[-- Type: text/x-diff, Size: 1011 bytes --]

From b9e5b9cd345495ee7b4684738c2da277f9feacae Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Wed, 17 Feb 2021 10:23:09 +0100
Subject: [PATCH] go: update to 1.16

---
 srcpkgs/go/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 186575b0676..20781ce682d 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.15.8
+version=1.16
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -9,8 +9,9 @@ short_desc="Go Programming Language"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="http://golang.org/"
+changelog="https://golang.org/doc/devel/release.html"
 distfiles="https://golang.org/dl/go${version}.src.tar.gz"
-checksum=540c0ab7781084d124991321ed1458e479982de94454a98afab6acadf38497c2
+checksum=7688063d55656105898f323d90a79a39c378d86fe89ae192eb3b7fc46347c95a
 nostrip=yes
 noverifyrdeps=yes
 

Re: go: update to 1.16

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-780870153

Comment:
INSTALL.msg is reserved for thing that will break your system if you don't attend to them (think sshd updates that require immediate restart).  Since this is just a compiler, we should not ship an installer message for it.  The build_style though should be updated to remove the now obsolete variables.

Re: go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-781470555

Comment:
Sorry, but I'm not sure about what should be changed. The build style seems to work fine. Which variables are obsolete?

Re: go: update to 1.16

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-781502744

Comment:
Void i686 does require SSE2: https://github.com/void-linux/void-packages/issues/21486 , https://docs.voidlinux.org/installation/index.html

Re: go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

New comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-781511499

Comment:
> Void i686 does require SSE2: #21486 , https://docs.voidlinux.org/installation/index.html

I remember reading somewhere that Void i686 was without SSE2, but apparently I'm wrong. Well, better that way.

Re: go: update to 1.16

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-781828607

Comment:
@4ricci its not entirely clear to me if the `GOPATH` is still in use.  If it is not, then the configuration logic in `common/build-style/go.sh` should be removed.  

Re: [PR PATCH] [Updated] go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 2125 bytes --]

There is an updated pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages go
https://github.com/void-linux/void-packages/pull/28825

go: update to 1.16
<!-- Mark items with [x] where applicable -->
Tested on x86_64-glibc.

~~According to the release notes, this version no more supports x87 on the 386 arch, but only SSE2 and softfloat. I think SSE2 was the default even in older releases.
Since Void's i686 port must not require SSE2, we should both export `GO386=softfloat` when building the compiler (if needed) and set it as the default for the package. I don't know how to do it however. Setting it in `do_build()` makes the build fail.~~

Also, `GO111MODULE` now defaults to `on` instead of `auto`. Should we provide an INSTALL.msg?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28825.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-28825.patch --]
[-- Type: text/x-diff, Size: 1802 bytes --]

From b9e5b9cd345495ee7b4684738c2da277f9feacae Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Wed, 17 Feb 2021 10:23:09 +0100
Subject: [PATCH 1/2] go: update to 1.16

---
 srcpkgs/go/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 186575b0676..20781ce682d 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.15.8
+version=1.16
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -9,8 +9,9 @@ short_desc="Go Programming Language"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="http://golang.org/"
+changelog="https://golang.org/doc/devel/release.html"
 distfiles="https://golang.org/dl/go${version}.src.tar.gz"
-checksum=540c0ab7781084d124991321ed1458e479982de94454a98afab6acadf38497c2
+checksum=7688063d55656105898f323d90a79a39c378d86fe89ae192eb3b7fc46347c95a
 nostrip=yes
 noverifyrdeps=yes
 

From 06bd8863f6046ab23d3f6330b0ed48b4809899d5 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Fri, 19 Feb 2021 16:56:32 +0100
Subject: [PATCH 2/2] build-style/go: set GO111MODULE=off when using GOPATH

---
 common/build-style/go.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index c9f476b95c7..7b1209f4b3b 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -36,6 +36,7 @@ do_build() {
 		go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
 	else
 		# Otherwise, build using GOPATH
+		export GO111MODULE=off
 		go get -p "$XBPS_MAKEJOBS" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
 	fi
 }

Re: go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

New comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-782176506

Comment:
`GOPATH` mode is still supported but now it's not enabled by default. Almost all of our packages use modules, but some use `GOPATH`, so it can't be removed from the build style.
Theese few packages need `GO111MODULE=off` (or `=auto`). For instance, `keybase` does not build with go-1.16 and the current build style (I didn't notice this before).

Re: go: update to 1.16

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-782572720

Comment:
`vmdfmt` will probably fail to build as well.

Re: go: update to 1.16

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-782574832

Comment:
vmdfmt is a disaster zone, I'm not convinced that we need to hold the release on it.

Re: go: update to 1.16

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-784740352

Comment:
So, Go 1.16 seems to be behaving very weirdly

See https://gist.github.com/Foxboron/94163c11a2c43ab523d3bc5597e4c49d

And from IRC:

```
2021-02-23 12:01:55     ericonr Foxboron: what exactly am I looking at? are the results different just because of the command you used?
2021-02-23 12:02:03     Foxboron        ericonr: Yes
2021-02-23 12:02:43     Foxboron        ericonr: It's intended. -buildmode=pie uses another codepath that doesn't always include cgo. That introduces a 2 year old bug nobody has figured out where sometimes Go decides to not include CGO even if requested.
2021-02-23 12:03:01     Foxboron        The workaround is to always use -ldflags=-extldflags. But you can't win that fight with GOFLAGS since the parser is broken
```

Re: go: update to 1.16

[ernierasta]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by ernierasta on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-787877733

Comment:
Hi! Any news on that? I would love to have 1.16 in repo. ;-)

Re: go: update to 1.16

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-787878622

Comment:
Resources are spread a bit thin right now with the gear up for the openssl rebuild.  Your patience is greatly appreciated.

Re: [PR PATCH] [Updated] go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 2125 bytes --]

There is an updated pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages go
https://github.com/void-linux/void-packages/pull/28825

go: update to 1.16
<!-- Mark items with [x] where applicable -->
Tested on x86_64-glibc.

~~According to the release notes, this version no more supports x87 on the 386 arch, but only SSE2 and softfloat. I think SSE2 was the default even in older releases.
Since Void's i686 port must not require SSE2, we should both export `GO386=softfloat` when building the compiler (if needed) and set it as the default for the package. I don't know how to do it however. Setting it in `do_build()` makes the build fail.~~

Also, `GO111MODULE` now defaults to `on` instead of `auto`. Should we provide an INSTALL.msg?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28825.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-28825.patch --]
[-- Type: text/x-diff, Size: 1806 bytes --]

From eb113d47bd7f798fe016b99b1caec3a53adf8439 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Wed, 17 Feb 2021 10:23:09 +0100
Subject: [PATCH 1/2] go: update to 1.16.1

---
 srcpkgs/go/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 186575b0676..14996509dd6 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.15.8
+version=1.16.1
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -9,8 +9,9 @@ short_desc="Go Programming Language"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="http://golang.org/"
+changelog="https://golang.org/doc/devel/release.html"
 distfiles="https://golang.org/dl/go${version}.src.tar.gz"
-checksum=540c0ab7781084d124991321ed1458e479982de94454a98afab6acadf38497c2
+checksum=680a500cd8048750121677dd4dc055fdfd680ae83edc7ed60a4b927e466228eb
 nostrip=yes
 noverifyrdeps=yes
 

From 9bacb0178c9a27aee6ebb1be1ea3dc7dcb3d08fb Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Thu, 11 Mar 2021 01:14:23 +0100
Subject: [PATCH 2/2] build-style/go: set GO111MODULE=off when using GOPATH

---
 common/build-style/go.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index c9f476b95c7..7b1209f4b3b 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -36,6 +36,7 @@ do_build() {
 		go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
 	else
 		# Otherwise, build using GOPATH
+		export GO111MODULE=off
 		go get -p "$XBPS_MAKEJOBS" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
 	fi
 }

Re: [PR PATCH] [Updated] go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 2125 bytes --]

There is an updated pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages go
https://github.com/void-linux/void-packages/pull/28825

go: update to 1.16
<!-- Mark items with [x] where applicable -->
Tested on x86_64-glibc.

~~According to the release notes, this version no more supports x87 on the 386 arch, but only SSE2 and softfloat. I think SSE2 was the default even in older releases.
Since Void's i686 port must not require SSE2, we should both export `GO386=softfloat` when building the compiler (if needed) and set it as the default for the package. I don't know how to do it however. Setting it in `do_build()` makes the build fail.~~

Also, `GO111MODULE` now defaults to `on` instead of `auto`. Should we provide an INSTALL.msg?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28825.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-28825.patch --]
[-- Type: text/x-diff, Size: 1806 bytes --]

From 5ccc677eceefefa8c0b8d9c73fe4bb4fe6620e19 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Wed, 17 Feb 2021 10:23:09 +0100
Subject: [PATCH 1/2] go: update to 1.16.1

---
 srcpkgs/go/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 25f339b6e58..14996509dd6 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.15.9
+version=1.16.1
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -9,8 +9,9 @@ short_desc="Go Programming Language"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="http://golang.org/"
+changelog="https://golang.org/doc/devel/release.html"
 distfiles="https://golang.org/dl/go${version}.src.tar.gz"
-checksum=90983b9c84a92417337dc1942ff066fc8b3a69733b8b5493fd0b9b9db1ead60f
+checksum=680a500cd8048750121677dd4dc055fdfd680ae83edc7ed60a4b927e466228eb
 nostrip=yes
 noverifyrdeps=yes
 

From 2c217dfc5af57215b83afde04fa4258462c174e3 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Thu, 11 Mar 2021 01:14:23 +0100
Subject: [PATCH 2/2] build-style/go: set GO111MODULE=off when using GOPATH

---
 common/build-style/go.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index d18116ee963..a32610772a9 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -36,6 +36,7 @@ do_build() {
 		go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
 	else
 		# Otherwise, build using GOPATH
+		export GO111MODULE=off
 		go get -p "$XBPS_MAKEJOBS" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
 	fi
 }

Re: [PR REVIEW] go: update to 1.16

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#discussion_r592581990

Comment:
I had thought of using `GO111MODULE=auto` in the entire environment, but this might work just as well, I guess.

Re: [PR PATCH] [Updated] go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 2125 bytes --]

There is an updated pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages go
https://github.com/void-linux/void-packages/pull/28825

go: update to 1.16
<!-- Mark items with [x] where applicable -->
Tested on x86_64-glibc.

~~According to the release notes, this version no more supports x87 on the 386 arch, but only SSE2 and softfloat. I think SSE2 was the default even in older releases.
Since Void's i686 port must not require SSE2, we should both export `GO386=softfloat` when building the compiler (if needed) and set it as the default for the package. I don't know how to do it however. Setting it in `do_build()` makes the build fail.~~

Also, `GO111MODULE` now defaults to `on` instead of `auto`. Should we provide an INSTALL.msg?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28825.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-28825.patch --]
[-- Type: text/x-diff, Size: 1834 bytes --]

From 5ccc677eceefefa8c0b8d9c73fe4bb4fe6620e19 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Wed, 17 Feb 2021 10:23:09 +0100
Subject: [PATCH 1/2] go: update to 1.16.1

---
 srcpkgs/go/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 25f339b6e589..14996509dd64 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.15.9
+version=1.16.1
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -9,8 +9,9 @@ short_desc="Go Programming Language"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="http://golang.org/"
+changelog="https://golang.org/doc/devel/release.html"
 distfiles="https://golang.org/dl/go${version}.src.tar.gz"
-checksum=90983b9c84a92417337dc1942ff066fc8b3a69733b8b5493fd0b9b9db1ead60f
+checksum=680a500cd8048750121677dd4dc055fdfd680ae83edc7ed60a4b927e466228eb
 nostrip=yes
 noverifyrdeps=yes
 

From 049f9526afa1443fc7fbcd757b4c13e1f0bbbd69 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Thu, 11 Mar 2021 19:56:12 +0100
Subject: [PATCH 2/2] build-style/go: set GO111MODULE=auto

---
 common/environment/build-style/go.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/environment/build-style/go.sh b/common/environment/build-style/go.sh
index 337b5279d0eb..6bdf6529a8c9 100644
--- a/common/environment/build-style/go.sh
+++ b/common/environment/build-style/go.sh
@@ -39,6 +39,7 @@ export CGO_CPPFLAGS="$CPPFLAGS"
 export CGO_CXXFLAGS="$CXXFLAGS"
 export CGO_LDFLAGS="$LDFLAGS"
 export CGO_ENABLED=1
+export GO111MODULE=auto
 case "$XBPS_TARGET_MACHINE" in
 	*-musl) export GOCACHE="${XBPS_HOSTDIR}/gocache-muslc" ;;
 	*)	export GOCACHE="${XBPS_HOSTDIR}/gocache-glibc" ;;

Re: [PR PATCH] [Updated] go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 2125 bytes --]

There is an updated pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages go
https://github.com/void-linux/void-packages/pull/28825

go: update to 1.16
<!-- Mark items with [x] where applicable -->
Tested on x86_64-glibc.

~~According to the release notes, this version no more supports x87 on the 386 arch, but only SSE2 and softfloat. I think SSE2 was the default even in older releases.
Since Void's i686 port must not require SSE2, we should both export `GO386=softfloat` when building the compiler (if needed) and set it as the default for the package. I don't know how to do it however. Setting it in `do_build()` makes the build fail.~~

Also, `GO111MODULE` now defaults to `on` instead of `auto`. Should we provide an INSTALL.msg?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28825.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-28825.patch --]
[-- Type: text/x-diff, Size: 1830 bytes --]

From 6ad9eae1c90e44b2818a1f2104161476d3a95ac0 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Fri, 12 Mar 2021 14:11:11 +0100
Subject: [PATCH 1/2] build-style/go: set GO111MODULE=auto

---
 common/environment/build-style/go.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/environment/build-style/go.sh b/common/environment/build-style/go.sh
index 337b5279d0e..6bdf6529a8c 100644
--- a/common/environment/build-style/go.sh
+++ b/common/environment/build-style/go.sh
@@ -39,6 +39,7 @@ export CGO_CPPFLAGS="$CPPFLAGS"
 export CGO_CXXFLAGS="$CXXFLAGS"
 export CGO_LDFLAGS="$LDFLAGS"
 export CGO_ENABLED=1
+export GO111MODULE=auto
 case "$XBPS_TARGET_MACHINE" in
 	*-musl) export GOCACHE="${XBPS_HOSTDIR}/gocache-muslc" ;;
 	*)	export GOCACHE="${XBPS_HOSTDIR}/gocache-glibc" ;;

From 5707cf4541d50e802405fb9170dbaa0846508890 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Fri, 12 Mar 2021 14:12:02 +0100
Subject: [PATCH 2/2] go: update to 1.16.2

---
 srcpkgs/go/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 25f339b6e58..652abe8806b 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.15.9
+version=1.16.2
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -9,8 +9,9 @@ short_desc="Go Programming Language"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="http://golang.org/"
+changelog="https://golang.org/doc/devel/release.html"
 distfiles="https://golang.org/dl/go${version}.src.tar.gz"
-checksum=90983b9c84a92417337dc1942ff066fc8b3a69733b8b5493fd0b9b9db1ead60f
+checksum=37ca14287a23cb8ba2ac3f5c3dd8adbc1f7a54b9701a57824bf19a0b271f83ea
 nostrip=yes
 noverifyrdeps=yes
 

Re: [PR REVIEW] go: update to 1.16

[travankor]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

New review comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#discussion_r594035573

Comment:
If it's only a few templates, then wouldn't this be better per-template since `GOPATH` is deprecated?

Secondly, new packages shouldn't be using the old behavior.

Re: [PR REVIEW] go: update to 1.16

[travankor]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New review comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#discussion_r594035573

Comment:
If it's only a few templates broken, then wouldn't this be better per-template since `GOPATH` is deprecated?

Secondly, new packages shouldn't be using the old behavior.

Re: go: update to 1.16

[kaey]

[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]

New comment by kaey on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-799257479

Comment:
> So, Go 1.16 seems to be behaving very weirdly
> 
> See https://gist.github.com/Foxboron/94163c11a2c43ab523d3bc5597e4c49d
> 
> And from IRC:
> 
> ```
> 2021-02-23 12:01:55     ericonr Foxboron: what exactly am I looking at? are the results different just because of the command you used?
> 2021-02-23 12:02:03     Foxboron        ericonr: Yes
> 2021-02-23 12:02:43     Foxboron        ericonr: It's intended. -buildmode=pie uses another codepath that doesn't always include cgo. That introduces a 2 year old bug nobody has figured out where sometimes Go decides to not include CGO even if requested.
> 2021-02-23 12:03:01     Foxboron        The workaround is to always use -ldflags=-extldflags. But you can't win that fight with GOFLAGS since the parser is broken
> ```

`ldflags` in this example are incorrect. it should be `-ldflags=all=-linkmode=external`.
In any case FORTIFY_SOURCE is completely useless for pure go binaries (which fzf is) and RELRO is useless (IIUC) for static binaries, which is again true for pure go binaries.

Re: [PR REVIEW] go: update to 1.16

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#discussion_r594309129

Comment:
I don't think it's only a few, we have a lot of old Go stuff. But I don't want to deal with fixing them now. If you want to make a subsequent PR fixing them, I'd appreciate it, tho. I might even have an indirect list of packages that aren't using go modules, will have to check.

Re: [PR PATCH] [Merged]: go: update to 1.16

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1976 bytes --]

There's a merged pull request on the void-packages repository

go: update to 1.16
https://github.com/void-linux/void-packages/pull/28825

Description:
<!-- Mark items with [x] where applicable -->
Tested on x86_64-glibc.

~~According to the release notes, this version no more supports x87 on the 386 arch, but only SSE2 and softfloat. I think SSE2 was the default even in older releases.
Since Void's i686 port must not require SSE2, we should both export `GO386=softfloat` when building the compiler (if needed) and set it as the default for the package. I don't know how to do it however. Setting it in `do_build()` makes the build fail.~~

Also, `GO111MODULE` now defaults to `on` instead of `auto`. Should we provide an INSTALL.msg?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

[PR PATCH] go: update to 1.16

[endigma]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

There is a new pull request by endigma against master on the void-packages repository

https://github.com/endigma/void-packages patch-2
https://github.com/void-linux/void-packages/pull/29054

go: update to 1.16


A patch file from https://github.com/void-linux/void-packages/pull/29054.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-29054.patch --]
[-- Type: text/x-diff, Size: 915 bytes --]

From 1ce96d7216ca6f4ea3d399a98c8e5b8f9f3d969a Mon Sep 17 00:00:00 2001
From: endigma <endigmamc@gmail.com>
Date: Thu, 25 Feb 2021 11:36:52 -0400
Subject: [PATCH] go: update to 1.16

---
 srcpkgs/go/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 186575b0676..6c21c781cec 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.15.8
+version=1.16
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -10,7 +10,7 @@ maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="http://golang.org/"
 distfiles="https://golang.org/dl/go${version}.src.tar.gz"
-checksum=540c0ab7781084d124991321ed1458e479982de94454a98afab6acadf38497c2
+checksum=7688063d55656105898f323d90a79a39c378d86fe89ae192eb3b7fc46347c95a
 nostrip=yes
 noverifyrdeps=yes
 

[PR PATCH] go: update to 1.16

[saqfish]

[-- Attachment #1: Type: text/plain, Size: 724 bytes --]

There is a new pull request by saqfish against master on the void-packages repository

https://github.com/saqfish/void-packages go
https://github.com/void-linux/void-packages/pull/29026

go: update to 1.16
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/29026.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-29026.patch --]
[-- Type: text/x-diff, Size: 913 bytes --]

From 2fdb3f5190ed30eb6a14873f376c243b2d509a56 Mon Sep 17 00:00:00 2001
From: saqfish <saqfish@gmail.com>
Date: Wed, 24 Feb 2021 07:02:23 -0600
Subject: [PATCH] go: update to 1.16

---
 srcpkgs/go/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 186575b0676..6c21c781cec 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.15.8
+version=1.16
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -10,7 +10,7 @@ maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="http://golang.org/"
 distfiles="https://golang.org/dl/go${version}.src.tar.gz"
-checksum=540c0ab7781084d124991321ed1458e479982de94454a98afab6acadf38497c2
+checksum=7688063d55656105898f323d90a79a39c378d86fe89ae192eb3b7fc46347c95a
 nostrip=yes
 noverifyrdeps=yes