Development discussion of WireGuard
 help / color / mirror / Atom feed
* [PATCH] Edited RU translation to avoid misunderstanding
@ 2023-12-19 15:59 Roman Lesechko
  2023-12-20  7:59 ` Michael Tokarev
  0 siblings, 1 reply; 4+ messages in thread
From: Roman Lesechko @ 2023-12-19 15:59 UTC (permalink / raw)
  To: wireguard; +Cc: Roman Lesechko

I have edited RU translations of "macToggleStatusButton" on the main screen. In english button's caption is imperative: Activate/Deactivate. Current russian translation is wrong in terms of tenses. For example, Wireguard is deactivated, but the button's caption says it is already active.

Signed-off-by: Roman Lesechko <polo-ru@yandex.ru>
---
 Sources/WireGuardApp/ru.lproj/Localizable.strings | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Sources/WireGuardApp/ru.lproj/Localizable.strings b/Sources/WireGuardApp/ru.lproj/Localizable.strings
index c05a566..ab148dc 100644
--- a/Sources/WireGuardApp/ru.lproj/Localizable.strings
+++ b/Sources/WireGuardApp/ru.lproj/Localizable.strings
@@ -55,9 +55,9 @@
 "tunnelStatusRestarting" = "Перезапуск";
 "tunnelStatusWaiting" = "Ожидание";
 
-"macToggleStatusButtonActivate" = "Подключен";
+"macToggleStatusButtonActivate" = "Подключить";
 "macToggleStatusButtonActivating" = "Подключение…";
-"macToggleStatusButtonDeactivate" = "Отключен";
+"macToggleStatusButtonDeactivate" = "Отключить";
 "macToggleStatusButtonDeactivating" = "Отключение…";
 "macToggleStatusButtonReasserting" = "Переподключение…";
 "macToggleStatusButtonRestarting" = "Перезапуск…";
@@ -111,7 +111,7 @@
 "tunnelOnDemandAddMessageAddNewSSID" = "Добавить новый";
 
 "tunnelOnDemandKey" = "Автоподключение";
-"tunnelOnDemandOptionOff" = "Выключить";
+"tunnelOnDemandOptionOff" = "Отключено";
 "tunnelOnDemandOptionWiFiOnly" = "Только Wi-Fi";
 "tunnelOnDemandOptionWiFiOrCellular" = "Wi-Fi или сотовая сеть";
 "tunnelOnDemandOptionCellularOnly" = "Только Сотовая сеть";
@@ -134,7 +134,7 @@
 "tunnelEditPlaceholderTextStronglyRecommended" = "Настоятельно рекомендуется";
 "tunnelEditPlaceholderTextOff" = "Выключить";
 
-"tunnelPeerPersistentKeepaliveValue (%@)" = "каждые %@ - интервал в секундах";
+"tunnelPeerPersistentKeepaliveValue (%@)" = "каждые %@ секунд";
 "tunnelHandshakeTimestampNow" = "Сейчас";
 "tunnelHandshakeTimestampSystemClockBackward" = "(Системные часы переведены назад)";
 "tunnelHandshakeTimestampAgo (%@)" = "%@ назад";
-- 
2.37.1 (Apple Git-137.1)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Edited RU translation to avoid misunderstanding
  2023-12-19 15:59 [PATCH] Edited RU translation to avoid misunderstanding Roman Lesechko
@ 2023-12-20  7:59 ` Michael Tokarev
  2023-12-20 12:19   ` Roman Mamedov
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Tokarev @ 2023-12-20  7:59 UTC (permalink / raw)
  To: Roman Lesechko, wireguard

19.12.2023 18:59, Roman Lesechko :
> I have edited RU translations of "macToggleStatusButton" on the main screen. In english button's caption is imperative: Activate/Deactivate. Current russian translation is wrong in terms of tenses. For example, Wireguard is deactivated, but the button's caption says it is already active.
> 
> Signed-off-by: Roman Lesechko <polo-ru@yandex.ru>

> -"tunnelPeerPersistentKeepaliveValue (%@)" = "каждые %@ - интервал в секундах";
> +"tunnelPeerPersistentKeepaliveValue (%@)" = "каждые %@ секунд";

Personally I would keep this one as it was.  Yes it is a bit ugly but it is better
for, say, 2 or 3 seconds.

/mjt


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Edited RU translation to avoid misunderstanding
  2023-12-20  7:59 ` Michael Tokarev
@ 2023-12-20 12:19   ` Roman Mamedov
       [not found]     ` <802041703091998@mail.yandex.ru>
  0 siblings, 1 reply; 4+ messages in thread
From: Roman Mamedov @ 2023-12-20 12:19 UTC (permalink / raw)
  To: Michael Tokarev; +Cc: Roman Lesechko, wireguard

On Wed, 20 Dec 2023 10:59:40 +0300
Michael Tokarev <mjt@tls.msk.ru> wrote:

> 19.12.2023 18:59, Roman Lesechko :
> > I have edited RU translations of "macToggleStatusButton" on the main screen. In english button's caption is imperative: Activate/Deactivate. Current russian translation is wrong in terms of tenses. For example, Wireguard is deactivated, but the button's caption says it is already active.
> > 
> > Signed-off-by: Roman Lesechko <polo-ru@yandex.ru>
> 
> > -"tunnelPeerPersistentKeepaliveValue (%@)" = "каждые %@ - интервал в секундах";
> > +"tunnelPeerPersistentKeepaliveValue (%@)" = "каждые %@ секунд";
> 
> Personally I would keep this one as it was.  Yes it is a bit ugly but it is better
> for, say, 2 or 3 seconds.

The old one is way too awkward and still wrong for when it's 1.

To handle the case of 2 or 3 it can be "каждые %@ сек."

In this format it's impossible to reach perfection (as in Russian the words
before and after the number also need to change inflection depending on the
actual value). But even as proposed in the patch, I'd say it is better than
before.

-- 
With respect,
Roman

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Edited RU translation to avoid misunderstanding
       [not found]     ` <802041703091998@mail.yandex.ru>
@ 2023-12-20 17:56       ` Michael Tokarev
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2023-12-20 17:56 UTC (permalink / raw)
  To: Roman Lesechko, Roman Mamedov; +Cc: wireguard

20.12.2023 20:20, Roman Lesechko пишет:
> With "секунд" I just tried to comply with english source. This option will be OK for the most numbers of seconds out of 60. If it's OK to use short 
> form I agree that "сек." is much better and won't cause any problems with understanding.
> My concern and main reason for patch is the part with status updates.
> -"macToggleStatusButtonActivate" = "Подключен";
> +"macToggleStatusButtonActivate" = "Подключить";
> -"macToggleStatusButtonDeactivate" = "Отключен";
> +"macToggleStatusButtonDeactivate" = "Отключить";
> -"tunnelOnDemandOptionOff" = "Выключить";
> +"tunnelOnDemandOptionOff" = "Отключено";

Yes, these definitely needs to go in, as currently
the meaning is just the opposite of reality.

/mjt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-12-20 17:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-19 15:59 [PATCH] Edited RU translation to avoid misunderstanding Roman Lesechko
2023-12-20  7:59 ` Michael Tokarev
2023-12-20 12:19   ` Roman Mamedov
     [not found]     ` <802041703091998@mail.yandex.ru>
2023-12-20 17:56       ` Michael Tokarev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).