zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org, zsh-workers@zsh.org
Cc: Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH] jp: fix segfaults during parameter expansion
Date: Sun, 21 Jan 2018 09:43:26 -0800	[thread overview]
Message-ID: <180121094326.ZM11602@torch.brasslantern.com> (raw)
In-Reply-To: <20180121014758.lu7vt7qg4kuup5qd@gmail.com>

On Jan 20,  3:47pm, Joey Pabalinas wrote:
} 
} Incorpated your changes, although I feel like the conditional operator is
} a better fit here (simpler and much more concise; making each possibility a
} lone function call is one of the few uses of `?:` where the intent is
} flat-out obvious).

There's no reason to do both of these changes.  You do the first one if
you like the "reference used with array" error message, or you do the
second one if you like the "not an identifier" message.  The second
one will never take the dupstring() branch if you have done the first.


  reply	other threads:[~2018-01-21 17:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14  6:05 Joey Pabalinas
2018-01-14 12:06 ` Bart Schaefer
2018-01-14 12:07   ` Bart Schaefer
2018-01-14 14:05     ` [PATCH v2] " Joey Pabalinas
2018-01-14 14:01   ` [PATCH] " Joey Pabalinas
2018-01-14 14:10   ` dana
2018-01-20 16:16   ` Daniel Tameling
2018-01-20 23:38     ` Joey Pabalinas
2018-01-21  0:03     ` Bart Schaefer
2018-01-21  1:47       ` Joey Pabalinas
2018-01-21 17:43         ` Bart Schaefer [this message]
2018-01-21 20:28           ` Joey Pabalinas
2018-01-21 22:42             ` Bart Schaefer
2018-01-21 22:46               ` Joey Pabalinas
2018-01-21 20:29           ` Joey Pabalinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=180121094326.ZM11602@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=joeypabalinas@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).