zsh-workers
 help / color / mirror / code / Atom feed
From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] jp: fix segfaults during parameter expansion
Date: Sun, 21 Jan 2018 10:28:36 -1000	[thread overview]
Message-ID: <20180121202836.77alwuapsgbwzsbr@gmail.com> (raw)
In-Reply-To: <180121094326.ZM11602@torch.brasslantern.com>

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

On Sun, Jan 21, 2018 at 09:43:26AM -0800, Bart Schaefer wrote:
> 
> There's no reason to do both of these changes.  You do the first one if
> you like the "reference used with array" error message, or you do the
> second one if you like the "not an identifier" message.  The second
> one will never take the dupstring() branch if you have done the first.

Noted, I feel like the "not an identifier message", although strange,
is more useful here. That one at least sort of makes sense; the other
"reference used with array" message took a few minutes digging
through the source to even figure out what that even meant
in normal context.

When i send updated patches, what's the best format? A new email after
a separate response mail, or as a single email with the response
at the bottom (or some other third option, maybe)?

Sending this one as its own separate mail for now.

-- 
Joey Pabalinas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-01-21 20:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14  6:05 Joey Pabalinas
2018-01-14 12:06 ` Bart Schaefer
2018-01-14 12:07   ` Bart Schaefer
2018-01-14 14:05     ` [PATCH v2] " Joey Pabalinas
2018-01-14 14:01   ` [PATCH] " Joey Pabalinas
2018-01-14 14:10   ` dana
2018-01-20 16:16   ` Daniel Tameling
2018-01-20 23:38     ` Joey Pabalinas
2018-01-21  0:03     ` Bart Schaefer
2018-01-21  1:47       ` Joey Pabalinas
2018-01-21 17:43         ` Bart Schaefer
2018-01-21 20:28           ` Joey Pabalinas [this message]
2018-01-21 22:42             ` Bart Schaefer
2018-01-21 22:46               ` Joey Pabalinas
2018-01-21 20:29           ` Joey Pabalinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180121202836.77alwuapsgbwzsbr@gmail.com \
    --to=joeypabalinas@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).