zsh-workers
 help / color / mirror / code / Atom feed
From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] jp: fix segfaults during parameter expansion
Date: Sun, 21 Jan 2018 12:46:50 -1000	[thread overview]
Message-ID: <20180121224650.7uwge344dkbgoqh2@gmail.com> (raw)
In-Reply-To: <180121144256.ZM12835@torch.brasslantern.com>

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

On Sun, Jan 21, 2018 at 02:42:56PM -0800, Bart Schaefer wrote:
>
> Also generally one explains the patch first and puts the patch at the
> bottom, rather than having the patch in the middle of the text, although
> there can be common-sense exceptions if there's something about the
> code that's easier to explain after it has been seen.

Ah ok, gotcha. Will do it like that from now on.

-- 
Joey Pabalinas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-01-21 22:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14  6:05 Joey Pabalinas
2018-01-14 12:06 ` Bart Schaefer
2018-01-14 12:07   ` Bart Schaefer
2018-01-14 14:05     ` [PATCH v2] " Joey Pabalinas
2018-01-14 14:01   ` [PATCH] " Joey Pabalinas
2018-01-14 14:10   ` dana
2018-01-20 16:16   ` Daniel Tameling
2018-01-20 23:38     ` Joey Pabalinas
2018-01-21  0:03     ` Bart Schaefer
2018-01-21  1:47       ` Joey Pabalinas
2018-01-21 17:43         ` Bart Schaefer
2018-01-21 20:28           ` Joey Pabalinas
2018-01-21 22:42             ` Bart Schaefer
2018-01-21 22:46               ` Joey Pabalinas [this message]
2018-01-21 20:29           ` Joey Pabalinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180121224650.7uwge344dkbgoqh2@gmail.com \
    --to=joeypabalinas@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).