From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] jp: fix segfaults during parameter expansion
Date: Sun, 21 Jan 2018 10:29:40 -1000 [thread overview]
Message-ID: <20180121202940.rzrq6ymofbyxkp73@gmail.com> (raw)
In-Reply-To: <180121094326.ZM11602@torch.brasslantern.com>
[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]
Running:
> $ zsh -fc ': ${${(PAA)p[foo]}::=x}'` in current zsh versions causes:
>
> [1] 4441 segmentation fault (core dumped) zsh -fc ': ${${(PAA)p[foo]}::=x}'
Also happens when testing with machabot:
> 19:42 <jp> > : ${${(PAA)p[foo]}::=x}
> 19:42 <machabot> jp: zsh[248]: segfault at 0 ip b7dfcda3 sp bfeb9ebc
> error 4 in libc-2.13.so[b7d84000+149000]
Add a simple `dupstring(s)` fallback.
Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
Requested-by: Bart Schaefer <schaefer@brasslantern.com>
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Src/subst.c b/Src/subst.c
index d027e3d83cadc631a7..a265a187e8730868a9 100644
--- a/Src/subst.c
+++ b/Src/subst.c
@@ -2430,7 +2430,7 @@ paramsubst(LinkList l, LinkNode n, char **str, int qt, int pf_flags,
val = aval[0];
isarr = 0;
}
- s = dyncat(val, s);
+ s = val ? dyncat(val, s) : dupstring(s);
/* Now behave po-faced as if it was always like that... */
subexp = 0;
/*
--
2.16.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-01-21 20:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 6:05 Joey Pabalinas
2018-01-14 12:06 ` Bart Schaefer
2018-01-14 12:07 ` Bart Schaefer
2018-01-14 14:05 ` [PATCH v2] " Joey Pabalinas
2018-01-14 14:01 ` [PATCH] " Joey Pabalinas
2018-01-14 14:10 ` dana
2018-01-20 16:16 ` Daniel Tameling
2018-01-20 23:38 ` Joey Pabalinas
2018-01-21 0:03 ` Bart Schaefer
2018-01-21 1:47 ` Joey Pabalinas
2018-01-21 17:43 ` Bart Schaefer
2018-01-21 20:28 ` Joey Pabalinas
2018-01-21 22:42 ` Bart Schaefer
2018-01-21 22:46 ` Joey Pabalinas
2018-01-21 20:29 ` Joey Pabalinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180121202940.rzrq6ymofbyxkp73@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).