From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>,
Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH] jp: fix segfaults during parameter expansion
Date: Sun, 14 Jan 2018 04:01:34 -1000 [thread overview]
Message-ID: <20180114140134.dkltzozgs5mhh6ct@gmail.com> (raw)
In-Reply-To: <CAH+w=7bMF_Kzvme+5EVazsa2KKEHO2uh2-u_T0MSAx2H=zcXQg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
On Sun, Jan 14, 2018 at 04:06:09AM -0800, Bart Schaefer wrote:
>
> Thanks for tracking this down. Defensive programming is always good,
> but I think this is indicative of a problem further upstream.
>
> What's the expected output of that substitution?
No problem; to be quite honestly I don't think there is on, haha.
Okdana on irc pointed it out, and I just tracked it down cause
tracking down stuff like this is something I enjoy. When I found the
NULL dereferences it made me wonder "wtf is going on here anyway???" so
I asked:
> 20:30 <jp> also how in the fuck did you even find this
> 20:30 <jp> this is like something a fuzzer would pop out
> 20:30 <okdana> lol
> 20:31 <okdana> i was trying to assign a value to an association element
> through indirection
> 20:31 <okdana> the AA is nonsense because a single element can't have an
> array/association assigned to it obv
> 20:32 <okdana> i was just adding and removing stuff randomly to see what
> would work
so yeah :) Honestly, I mostly just wasn't comfortable with paramater
expansion segfaulting, heh.
On Sun, Jan 14, 2018 at 04:06:09AM -0800, Bart Schaefer wrote:
>
> The following prevents the segfault for me, instead giving the error
> "zsh: not an identifier: " (i.e., empty string is not a valid
> parameter name). But perhaps there's a different error that should
> occur here if val is NULL?
That actually helped me realize (imo) a simpler solution; working
on a [PATCH v2] right now.
--
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-01-14 14:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 6:05 Joey Pabalinas
2018-01-14 12:06 ` Bart Schaefer
2018-01-14 12:07 ` Bart Schaefer
2018-01-14 14:05 ` [PATCH v2] " Joey Pabalinas
2018-01-14 14:01 ` Joey Pabalinas [this message]
2018-01-14 14:10 ` [PATCH] " dana
2018-01-20 16:16 ` Daniel Tameling
2018-01-20 23:38 ` Joey Pabalinas
2018-01-21 0:03 ` Bart Schaefer
2018-01-21 1:47 ` Joey Pabalinas
2018-01-21 17:43 ` Bart Schaefer
2018-01-21 20:28 ` Joey Pabalinas
2018-01-21 22:42 ` Bart Schaefer
2018-01-21 22:46 ` Joey Pabalinas
2018-01-21 20:29 ` Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180114140134.dkltzozgs5mhh6ct@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).