Segfault with newer .zwc

Segfault with newer .zwc

[Jörg Sommer]

Hi,

I've built a zwc with “zcompile .zshrc” from the zsh-beta package in
Debian (last Changelog entry is 2007-12-27). When using this file with
zsh from the zsh package (last Changelog entry is 2007-12-20) it crashes.
I can start with this file, but accessing an alias defined in this file
the shell segfaults.

Further tests should it is much more tricky. My .zshrc and .zshenv are at
http://www.minet.uni-jena.de/~joergs/zshrc
http://www.minet.uni-jena.de/~joergs/zshenv
Starting zsh-beta as *normal* user compiles the .zshrc.zwc and
.zshenv.zwc. Starting then zsh as *root* and running agi test crashes the
shell.

I think the problem is this part:
    agi()
    {
        local rc=0
        ag install $@ || rc=$?
        check-etc
        deborphan
        return $rc
    }
    alias agi='noglob agi'

While this works don't doing that above, it creates a loop in the above
situation. gdb shows 1526 stack frames and repeats the following:

#1508 0x10027500 in execlist ()
#1509 0x100276cc in execode ()
#1510 0x10027834 in runshfunc ()
#1511 0x10027c70 in doshfunc ()
#1512 0x10025bf0 in ?? ()
#1513 0x10026124 in ?? ()
#1514 0x1002662c in ?? ()
#1515 0x10027500 in execlist ()
#1516 0x100276cc in execode ()
#1517 0x10027834 in runshfunc ()
#1518 0x10027c70 in doshfunc ()
#1519 0x10025bf0 in ?? ()
#1520 0x10026124 in ?? ()
#1521 0x1002662c in ?? ()
#1522 0x10027174 in execlist ()
#1523 0x100276cc in execode ()
#1524 0x1003a4b0 in loop ()
#1525 0x1003b3a4 in zsh_main ()
#1526 0x1000dc10 in main ()

Or is gdb broken?

Bye, Jörg.
-- 
Nichts ist so langweilig, wie die Wiederholung seinerselbst.
                                        (Marcel Reich‐Ranicki)

Re: Segfault with newer .zwc

[Peter Stephenson]

On Mon, 7 Jan 2008 17:39:51 +0000 (UTC)
Jörg Sommer <joerg@alea.gnuu.de> wrote:
> Hi,
> 
> I've built a zwc with “zcompile .zshrc” from the zsh-beta package in
> Debian (last Changelog entry is 2007-12-27). When using this file with
> zsh from the zsh package (last Changelog entry is 2007-12-20) it crashes.

You're not actually supposed to be able to use compiled files with
different versions of the shell.  There is a version number built in,
but unless the version number of the shell in the archive was
incremented in between (which is only done manually when I make a
release) this doesn't alert the shell to differences.

Most of the time this doesn't matter but if there is a change in parsing it
can make a difference.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: Segfault with newer .zwc

[Clint Adams]

On Tue, Jan 08, 2008 at 09:53:06AM +0000, Peter Stephenson wrote:
> > Debian (last Changelog entry is 2007-12-27). When using this file with
> > zsh from the zsh package (last Changelog entry is 2007-12-20) it crashes.
> 
> Most of the time this doesn't matter but if there is a change in parsing it
> can make a difference.

Was there a parsing change between 12-20 and 12-27?

I could inject a datestamp into the version string if this is a
significant issue.

Re: Segfault with newer .zwc

[Peter Stephenson]

Clint Adams wrote:
> On Tue, Jan 08, 2008 at 09:53:06AM +0000, Peter Stephenson wrote:
> > > Debian (last Changelog entry is 2007-12-27). When using this file with
> > > zsh from the zsh package (last Changelog entry is 2007-12-20) it crashes.
> > 
> > Most of the time this doesn't matter but if there is a change in parsing it
> > can make a difference.
> 
> Was there a parsing change between 12-20 and 12-27?

Not obviously, but if the complaint is that a wordcode file works with
one release but not another, which is how I read it, that's what's going
on.

> I could inject a datestamp into the version string if this is a
> significant issue.

That's probably a sensible idea, though to avoid confusing is-at-least
it would be best if it only appeared if there was a dev-N before it.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: Segfault with newer .zwc

[Clint Adams]

On Thu, Jan 10, 2008 at 09:50:23AM +0000, Peter Stephenson wrote:
> That's probably a sensible idea, though to avoid confusing is-at-least
> it would be best if it only appeared if there was a dev-N before it.

That shouldn't be a problem.

How about something like this?

Index: configure.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/configure.ac,v
retrieving revision 1.87
diff -u -r1.87 configure.ac
--- configure.ac	14 Dec 2007 15:14:05 -0000	1.87
+++ configure.ac	15 Jan 2008 02:04:59 -0000
@@ -31,6 +31,7 @@
 
 dnl What version of zsh are we building ?
 . ${srcdir}/Config/version.mk
+VERSION="$VERSION$ZSH_EXTRAVERSION"
 echo "configuring for zsh $VERSION"
 
 dnl ----------------------------------------------

Re: Segfault with newer .zwc

[Peter Stephenson]

Clint Adams wrote:
> How about something like this?
> 
> Index: configure.ac
>...
> +VERSION="$VERSION$ZSH_EXTRAVERSION"

That seems OK; it probably ought to be mentioned in
Etc/zsh-development-guide.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]

[Clint Adams]

On Tue, Jan 15, 2008 at 09:10:25AM +0000, Peter Stephenson wrote:
> That seems OK; it probably ought to be mentioned in
> Etc/zsh-development-guide.

I don't particularly like the way this sounds, but..

Index: configure.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/configure.ac,v
retrieving revision 1.87
diff -u -r1.87 configure.ac
--- configure.ac	14 Dec 2007 15:14:05 -0000	1.87
+++ configure.ac	18 Jan 2008 16:59:11 -0000
@@ -31,6 +31,7 @@
 
 dnl What version of zsh are we building ?
 . ${srcdir}/Config/version.mk
+VERSION="$VERSION$ZSH_EXTRAVERSION"
 echo "configuring for zsh $VERSION"
 
 dnl ----------------------------------------------
Index: Etc/zsh-development-guide
===================================================================
RCS file: /cvsroot/zsh/zsh/Etc/zsh-development-guide,v
retrieving revision 1.15
diff -u -r1.15 zsh-development-guide
--- Etc/zsh-development-guide	3 Dec 2007 19:04:09 -0000	1.15
+++ Etc/zsh-development-guide	18 Jan 2008 16:59:12 -0000
@@ -856,3 +856,13 @@
   distribution, but that need to be present in the CVS tree.  This
   variable is not used by the zsh build process and is present for
   the convenience of external checks.
+
+Version Suffixes
+----------------
+The configure script reads the version number from Config/version.mk.
+If the environment variable ZSH_EXTRAVERSION is set, the string
+contained therein will be appended to the version string.  For example,
+if Config/version.mk contains "VERSION=4.3.4-dev-7" and
+ZSH_EXTRAVERSION is set to "-ca", $ZSH_VERSION in the shell built from
+that run will equal "4.3.4-dev-7-ca".  Caution is recommended when
+using this feature, as is-at-least may misunderstand your conventions.

Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]

[Geoff Wing]

On Friday 2008-01-18 12:02 -0500, Clint Adams output:
:+Version Suffixes
:+----------------
:+The configure script reads the version number from Config/version.mk.
:+If the environment variable ZSH_EXTRAVERSION is set, the string
:+contained therein will be appended to the version string.  For example,
:+if Config/version.mk contains "VERSION=4.3.4-dev-7" and
:+ZSH_EXTRAVERSION is set to "-ca", $ZSH_VERSION in the shell built from
:+that run will equal "4.3.4-dev-7-ca".  Caution is recommended when
:+using this feature, as is-at-least may misunderstand your conventions.

Wouldn't it be nicer to call this ZSH_VERSIONSUFFIX?  IMO, it's a name
which is clearer about its function.

Regards,
Geoff

Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]

[Clint Adams]

On Mon, Jan 21, 2008 at 12:48:01PM +1100, Geoff Wing wrote:
> Wouldn't it be nicer to call this ZSH_VERSIONSUFFIX?  IMO, it's a name
> which is clearer about its function.

Fine by me.

Index: configure.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/configure.ac,v
retrieving revision 1.88
diff -u -r1.88 configure.ac
--- configure.ac	18 Jan 2008 17:14:38 -0000	1.88
+++ configure.ac	22 Jan 2008 01:34:51 -0000
@@ -31,7 +31,7 @@
 
 dnl What version of zsh are we building ?
 . ${srcdir}/Config/version.mk
-VERSION="$VERSION$ZSH_EXTRAVERSION"
+VERSION="$VERSION$ZSH_VERSIONSUFFIX"
 echo "configuring for zsh $VERSION"
 
 dnl ----------------------------------------------
Index: Etc/zsh-development-guide
===================================================================
RCS file: /cvsroot/zsh/zsh/Etc/zsh-development-guide,v
retrieving revision 1.16
diff -u -r1.16 zsh-development-guide
--- Etc/zsh-development-guide	18 Jan 2008 17:14:44 -0000	1.16
+++ Etc/zsh-development-guide	22 Jan 2008 01:34:51 -0000
@@ -860,9 +860,9 @@
 Version Suffixes
 ----------------
 The configure script reads the version number from Config/version.mk.
-If the environment variable ZSH_EXTRAVERSION is set, the string
+If the environment variable ZSH_VERSIONSUFFIX is set, the string
 contained therein will be appended to the version string.  For example,
 if Config/version.mk contains "VERSION=4.3.4-dev-7" and
-ZSH_EXTRAVERSION is set to "-ca", $ZSH_VERSION in the shell built from
+ZSH_VERSIONSUFFIX is set to "-ca", $ZSH_VERSION in the shell built from
 that run will equal "4.3.4-dev-7-ca".  Caution is recommended when
 using this feature, as is-at-least may misunderstand your conventions.

From zsh-workers-return-24429-mason-zsh=primenet.com.au@sunsite.dk Tue Jan 22 03:27:35 2008
Return-Path: <zsh-workers-return-24429-mason-zsh=primenet.com.au@sunsite.dk>
Delivered-To: mason-zsh@primenet.com.au
Received: (qmail 17450 invoked from network); 22 Jan 2008 03:27:33 -0000
X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00
	autolearn=unavailable version=3.2.4
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by ns1.primenet.com.au with SMTP; 22 Jan 2008 03:27:33 -0000
Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts)
Received: (qmail 19334 invoked from network); 22 Jan 2008 01:35:25 -0000
Received: from sunsite.dk (130.225.247.90)
  by a.mx.sunsite.dk with SMTP; 22 Jan 2008 01:35:25 -0000
Received: (qmail 14358 invoked by alias); 22 Jan 2008 01:35:22 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
Delivered-To: mailing list zsh-workers@sunsite.dk
X-Seq: 24429
Received: (qmail 14346 invoked from network); 22 Jan 2008 01:35:22 -0000
Received: from bifrost.dotsrc.org (130.225.254.106)
  by sunsite.dk with SMTP; 22 Jan 2008 01:35:22 -0000
Received: from virusfilter.dotsrc.org (bifrost [127.0.0.1])
	by spamfilter.dotsrc.org (Postfix) with ESMTP id 9E65B8058F58
	for <zsh-workers@sunsite.dk>; Tue, 22 Jan 2008 02:35:13 +0100 (CET)
Received: from acolyte.scowler.net (acolyte.scowler.net [216.254.112.45])
	by bifrost.dotsrc.org (Postfix) with ESMTP
	for <zsh-workers@sunsite.dk>; Tue, 22 Jan 2008 02:35:13 +0100 (CET)
Received: by acolyte.scowler.net (Postfix, from userid 1000)
	id AF4675C06B; Mon, 21 Jan 2008 20:35:17 -0500 (EST)
Date: Mon, 21 Jan 2008 20:35:17 -0500
From: Clint Adams <clint@zsh.org>
To: Geoff Wing <gcw@zsh.org>
Cc: zsh-workers@sunsite.dk
Subject: Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]
Message-ID: <20080122013517.GD16813@scowler.net>
Mail-Followup-To: Geoff Wing <gcw@zsh.org>, zsh-workers@sunsite.dk
References: <slrnfo4ov7.cgh.joerg@alea.gnuu.de> <20080108095306.5475d009@news01> <20080109191236.GB32394@scowler.net> <200801100950.m0A9oN9T015070@news01.csr.com> <20080115020642.GA5306@scowler.net> <200801150910.m0F9AP0f026468@news01.csr.com> <20080118170223.GA32039@scowler.net> <20080121014801.GA1242@primenet.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080121014801.GA1242@primenet.com.au>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Virus-Scanned: ClamAV using ClamSMTP

On Mon, Jan 21, 2008 at 12:48:01PM +1100, Geoff Wing wrote:
> Wouldn't it be nicer to call this ZSH_VERSIONSUFFIX?  IMO, it's a name
> which is clearer about its function.

Fine by me.

Index: configure.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/configure.ac,v
retrieving revision 1.88
diff -u -r1.88 configure.ac
--- configure.ac	18 Jan 2008 17:14:38 -0000	1.88
+++ configure.ac	22 Jan 2008 01:34:51 -0000
@@ -31,7 +31,7 @@
 
 dnl What version of zsh are we building ?
 . ${srcdir}/Config/version.mk
-VERSION="$VERSION$ZSH_EXTRAVERSION"
+VERSION="$VERSION$ZSH_VERSIONSUFFIX"
 echo "configuring for zsh $VERSION"
 
 dnl ----------------------------------------------
Index: Etc/zsh-development-guide
===================================================================
RCS file: /cvsroot/zsh/zsh/Etc/zsh-development-guide,v
retrieving revision 1.16
diff -u -r1.16 zsh-development-guide
--- Etc/zsh-development-guide	18 Jan 2008 17:14:44 -0000	1.16
+++ Etc/zsh-development-guide	22 Jan 2008 01:34:51 -0000
@@ -860,9 +860,9 @@
 Version Suffixes
 ----------------
 The configure script reads the version number from Config/version.mk.
-If the environment variable ZSH_EXTRAVERSION is set, the string
+If the environment variable ZSH_VERSIONSUFFIX is set, the string
 contained therein will be appended to the version string.  For example,
 if Config/version.mk contains "VERSION=4.3.4-dev-7" and
-ZSH_EXTRAVERSION is set to "-ca", $ZSH_VERSION in the shell built from
+ZSH_VERSIONSUFFIX is set to "-ca", $ZSH_VERSION in the shell built from
 that run will equal "4.3.4-dev-7-ca".  Caution is recommended when
 using this feature, as is-at-least may misunderstand your conventions.

ZSH_VERSIONSUFFIX [was Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]]

[Clint Adams]

On Mon, Jan 21, 2008 at 08:35:17PM -0500, Clint Adams wrote:
> +VERSION="$VERSION$ZSH_VERSIONSUFFIX"

So this actually doesn't work for reasons that should be obvious from
the ugly patch below. The suffix is lost in a ./config.status --recheck;
I don't know whether to view this as a feature or a bug.

Index: Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Makefile.in,v
retrieving revision 1.17
diff -u -r1.17 Makefile.in
--- Makefile.in	16 Sep 2006 15:53:03 -0000	1.17
+++ Makefile.in	1 Feb 2008 02:49:07 -0000
@@ -29,6 +29,7 @@
 SUBDIRS = Doc Etc Src Test
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@
Index: configure.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/configure.ac,v
retrieving revision 1.89
diff -u -r1.89 configure.ac
--- configure.ac	22 Jan 2008 01:59:26 -0000	1.89
+++ configure.ac	1 Feb 2008 02:49:08 -0000
@@ -33,6 +33,7 @@
 . ${srcdir}/Config/version.mk
 VERSION="$VERSION$ZSH_VERSIONSUFFIX"
 echo "configuring for zsh $VERSION"
+AC_SUBST(VERSION)
 
 dnl ----------------------------------------------
 dnl CHECK FOR MACHINE/VENDOR/OPERATING SYSTEM TYPE
Index: Doc/Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Makefile.in,v
retrieving revision 1.38
diff -u -r1.38 Makefile.in
--- Doc/Makefile.in	20 Nov 2007 14:20:00 -0000	1.38
+++ Doc/Makefile.in	1 Feb 2008 02:49:09 -0000
@@ -28,6 +28,7 @@
 dir_top = ..
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@
Index: Etc/Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Etc/Makefile.in,v
retrieving revision 1.2
diff -u -r1.2 Makefile.in
--- Etc/Makefile.in	3 Jul 2007 17:06:05 -0000	1.2
+++ Etc/Makefile.in	1 Feb 2008 02:49:09 -0000
@@ -29,6 +29,7 @@
 SUBDIRS =
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@
Index: Src/Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Makefile.in,v
retrieving revision 1.13
diff -u -r1.13 Makefile.in
--- Src/Makefile.in	24 Jul 2005 04:47:57 -0000	1.13
+++ Src/Makefile.in	1 Feb 2008 02:49:09 -0000
@@ -29,6 +29,7 @@
 SUBDIRS =
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@
Index: Src/Makemod.in.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Makemod.in.in,v
retrieving revision 1.5
diff -u -r1.5 Makemod.in.in
--- Src/Makemod.in.in	20 Dec 2001 23:48:39 -0000	1.5
+++ Src/Makemod.in.in	1 Feb 2008 02:49:09 -0000
@@ -31,6 +31,7 @@
 # SUBDIRS is done by mkmakemod.sh
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@
Index: Test/Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/Makefile.in,v
retrieving revision 1.9
diff -u -r1.9 Makefile.in
--- Test/Makefile.in	18 Dec 2007 21:16:30 -0000	1.9
+++ Test/Makefile.in	1 Feb 2008 02:49:09 -0000
@@ -29,6 +29,7 @@
 SUBDIRS = 
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@

Re: ZSH_VERSIONSUFFIX [was Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]]

[Peter Stephenson]

Clint Adams wrote:
> On Mon, Jan 21, 2008 at 08:35:17PM -0500, Clint Adams wrote:
> > +VERSION="$VERSION$ZSH_VERSIONSUFFIX"
> 
> So this actually doesn't work for reasons that should be obvious from
> the ugly patch below. The suffix is lost in a ./config.status --recheck;
> I don't know whether to view this as a feature or a bug.

After updating the version in Config/version.mk and running make, I now
have a top level Makefile containing:

VERSION=4.3.5
VERSION_DATE='February 1, 2008'
VERSION = 4.3.4-dev-8

so (i) the dependencies aren't right (ii) the new VERSION doesn't fit
with the version generated from version.mk---the way to import a VERSION
definition into makefiles and scripts is @VERSION_MK@.  I suspect you
want to do something like add ${ZSH_VERSIONSUFFIX} in version.mk (note
this needs to work in both shell scripts and Makefiles).

I don't want to wait yet more for 4.3.5, and obviously this isn't a
problem for a production version (though multiple definitions of the
version is), so I'll simply back this off for now.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: ZSH_VERSIONSUFFIX [was Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]]

[Peter Stephenson]

On Fri, 01 Feb 2008 11:22:10 +0000
Peter Stephenson <pws@csr.com> wrote:
> (i) the dependencies aren't right

Looking again, I think that's a pre-existing problem.  When I change
version.mk I need to run ./config.status by hand.  Nobody else really has
that problem, although it might be sensible to fix it to stop me releasing
out of date version information.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: ZSH_VERSIONSUFFIX [was Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]]

[Clint Adams]

On Fri, Feb 01, 2008 at 11:22:10AM +0000, Peter Stephenson wrote:
> so (i) the dependencies aren't right (ii) the new VERSION doesn't fit
> with the version generated from version.mk---the way to import a VERSION
> definition into makefiles and scripts is @VERSION_MK@.  I suspect you
> want to do something like add ${ZSH_VERSIONSUFFIX} in version.mk (note
> this needs to work in both shell scripts and Makefiles).

Maybe it's cleaner to just put the suffix in VERSION_SUFFIX and tack it
on in each individual place VERSION is used.