runhelpdir Issues with building Zsh 5.0.5 for Fedora

runhelpdir Issues with building Zsh 5.0.5 for Fedora

[Dominic Hopf]

[-- Attachment #1.1: Type: text/plain, Size: 2406 bytes --]

Greetings,

attached patch is at least necessary to successfully build the latest
Zsh release on Fedora, please have a look at it as it might be useful in
other cases as well or possibly also could be applied upstream.

Furthermore, I have to set the runhelpdir path to the buildroot of the
package as it happened before for several other paths as well. The
install-section of the RPM spec file looks like this then:

%makeinstall install.info \
  fndir=$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/functions \
  sitefndir=$RPM_BUILD_ROOT%{_datadir}/%{name}/site-functions \
  scriptdir=$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/scripts \
  sitescriptdir=$RPM_BUILD_ROOT%{_datadir}/%{name}/scripts \
  runhelpdir=$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/help


This unfortunately causes the whole path, including the buildroot itself
to be written into the files

    /usr/share/zsh/5.0.5/functions/{run-help,_run-help}

which of course will not work and is claimed by rpmbuild:

+ /usr/lib/rpm/check-buildroot
/home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5/functions/_run-help:local HELPDIR=${HELPDIR:-/home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5/help}
/home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5/functions/run-help:local HELPDIR="${HELPDIR:-/home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5/help}"
Found '/home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64' in
installed files; aborting
error: Bad exit status from /home/dmaphy/.tmp/rpm-tmp.kg39RI (%install)

Currently I'm fixing this in the package using sed to remove the
buildroot again where it is not needed:

sed -i "s!$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/help!
%{_datadir}/%{name}/%{version}/help!" \
	$RPM_BUILD_ROOT
%{_datadir}/zsh/%{version}/functions/{run-help,_run-help}


As far as I can see there is happening something weird with the
runhelpdir within the build process I didn't understand into detail but
luckily was able to fix so far.

I'd appreciate if someone could have a deeper look into this and tell me
if I ran into a bug or if I'm basically doing something wrong.


Thanks very much in advance & Best Regards,
Dominic

-- 
Dominic Hopf 
http://dominichopf.de/

Key Fingerprint: A7DF C4FC 07AE 4DDC 5CA0  BD93 AAB0 6019 CA7D 868D

[-- Attachment #1.2: 0000-zsh-fix-runhelpdir-issue.patch --]
[-- Type: text/x-patch, Size: 669 bytes --]

--- zsh-5.0.5/Config/defs.mk.in.original	2014-06-30 20:48:41.095977646 +0200
+++ zsh-5.0.5/Config/defs.mk.in	2014-06-30 20:49:06.132076698 +0200
@@ -95,7 +95,7 @@
 MAKEDEFS = \
 prefix='$(prefix)' exec_prefix='$(exec_prefix)' bindir='$(bindir)' \
 libdir='$(libdir)' MODDIR='$(MODDIR)' infodir='$(infodir)' mandir='$(mandir)' \
-datadir='$(datadir)' fndir='$(fndir)' htmldir='$(htmldir)' \
+datadir='$(datadir)' fndir='$(fndir)' htmldir='$(htmldir)' runhelpdir='$(runhelpdir)' \
 CC='$(CC)' CPPFLAGS='$(CPPFLAGS)' DEFS='$(DEFS)' CFLAGS='$(CFLAGS)' \
 LDFLAGS='$(LDFLAGS)' EXTRA_LDFLAGS='$(EXTRA_LDFLAGS)' \
 DLCFLAGS='$(DLCFLAGS)' DLLDFLAGS='$(DLLDFLAGS)' \

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: runhelpdir Issues with building Zsh 5.0.5 for Fedora

[Peter Stephenson]

On Thu, 03 Jul 2014 20:42:48 +0200
Dominic Hopf <dmaphy@googlemail.com> wrote:
> attached patch is at least necessary to successfully build the latest
> Zsh release on Fedora, please have a look at it as it might be useful in
> other cases as well or possibly also could be applied upstream.

Thanks, this looks obviously sane and I've applied it.

> As far as I can see there is happening something weird with the
> runhelpdir within the build process I didn't understand into detail but
> luckily was able to fix so far.

I can well believe this --- it's quite baroque --- but I haven't had a
chance to look into it so far.

pws