* Skipping gdbm test
@ 2017-03-01 19:41 ` Vin Shelton
2017-03-02 15:05 ` Peter Stephenson
0 siblings, 1 reply; 6+ messages in thread
From: Vin Shelton @ 2017-03-01 19:41 UTC (permalink / raw)
To: Zsh Hackers' List
[-- Attachment #1: Type: text/plain, Size: 563 bytes --]
Starting today, I am seeing 1 skipped test result:
/opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: starting.
(eval):3: failed to load module `zsh/db/gdbm':
/opt/build/zsh-2017-03-01/Test/Modules/zsh/db/gdbm.so: cannot open shared
object file: No such file or directory
/opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: skipped (can't load
zsh/db/gdbm module for testing)
/opt/src/zsh-2017-03-01/Test/W01history.ztst: starting.
This is on a sparky (basically debian testing) linux box. Yesterday, this
test passed.
Please let me know if you need more info.
- Vin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Skipping gdbm test
2017-03-01 19:41 ` Skipping gdbm test Vin Shelton
@ 2017-03-02 15:05 ` Peter Stephenson
2017-03-02 16:17 ` Sebastian Gniazdowski
0 siblings, 1 reply; 6+ messages in thread
From: Peter Stephenson @ 2017-03-02 15:05 UTC (permalink / raw)
To: Zsh Hackers' List
On Wed, 1 Mar 2017 14:41:29 -0500
Vin Shelton <acs@alumni.princeton.edu> wrote:
> Starting today, I am seeing 1 skipped test result:
>
> /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: starting.
> (eval):3: failed to load module `zsh/db/gdbm':
> /opt/build/zsh-2017-03-01/Test/Modules/zsh/db/gdbm.so: cannot open shared
> object file: No such file or directory
> /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: skipped (can't load
> zsh/db/gdbm module for testing)
> /opt/src/zsh-2017-03-01/Test/W01history.ztst: starting.
>
> This is on a sparky (basically debian testing) linux box. Yesterday, this
> test passed.
It's a new test --- skipping it is fine unless you think you have the
optional gdbm configured in. Otherwise, nothing to do.
The test was posted a couple of weeks ago but I only realised I hadn't
committed yesterday.
pws
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Skipping gdbm test
2017-03-02 15:05 ` Peter Stephenson
@ 2017-03-02 16:17 ` Sebastian Gniazdowski
2017-03-03 9:19 ` Peter Stephenson
0 siblings, 1 reply; 6+ messages in thread
From: Sebastian Gniazdowski @ 2017-03-02 16:17 UTC (permalink / raw)
To: zsh-workers
On Thu, Mar 2, 2017, at 07:05 AM, Peter Stephenson wrote:
> On Wed, 1 Mar 2017 14:41:29 -0500
> Vin Shelton <acs@alumni.princeton.edu> wrote:
> > /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: starting.
> > (eval):3: failed to load module `zsh/db/gdbm':
> > /opt/build/zsh-2017-03-01/Test/Modules/zsh/db/gdbm.so: cannot open shared
> > object file: No such file or directory
> > /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: skipped (can't load
> > zsh/db/gdbm module for testing)
(...)
> It's a new test --- skipping it is fine unless you think you have the
> optional gdbm configured in. Otherwise, nothing to do.
Maybe the skip could be done more quiet? I've followed V10private.tst,
but that module is easily built. Checked that in %prep path to gdbm
module file is: Modules/zsh/db/gdbm.so
--
Sebastian Gniazdowski
psprint3@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Skipping gdbm test
2017-03-02 16:17 ` Sebastian Gniazdowski
@ 2017-03-03 9:19 ` Peter Stephenson
2017-03-03 9:55 ` Daniel Shahaf
0 siblings, 1 reply; 6+ messages in thread
From: Peter Stephenson @ 2017-03-03 9:19 UTC (permalink / raw)
To: zsh-workers
On Thu, 02 Mar 2017 08:17:44 -0800
Sebastian Gniazdowski <psprint3@fastmail.com> wrote:
> Maybe the skip could be done more quiet? I've followed V10private.tst,
> but that module is easily built. Checked that in %prep path to gdbm
> module file is: Modules/zsh/db/gdbm.so
I don't think it's a problem. Skipping is common within tests, too,
depending on system features. It's just when something changes that
people notice.
pws
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Skipping gdbm test
2017-03-03 9:19 ` Peter Stephenson
@ 2017-03-03 9:55 ` Daniel Shahaf
2017-03-03 10:14 ` Peter Stephenson
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Shahaf @ 2017-03-03 9:55 UTC (permalink / raw)
To: Peter Stephenson; +Cc: zsh-workers
Peter Stephenson wrote on Fri, Mar 03, 2017 at 09:19:02 +0000:
> On Thu, 02 Mar 2017 08:17:44 -0800
> Sebastian Gniazdowski <psprint3@fastmail.com> wrote:
> > Maybe the skip could be done more quiet? I've followed V10private.tst,
> > but that module is easily built. Checked that in %prep path to gdbm
> > module file is: Modules/zsh/db/gdbm.so
>
> I don't think it's a problem. Skipping is common within tests, too,
> depending on system features. It's just when something changes that
> people notice.
I think the proposal was to removal lines 2,3 but keep lines 1,4:
>>>> 1 /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: starting.
>>>> 2 (eval):3: failed to load module `zsh/db/gdbm':
>>>> 3 /opt/build/zsh-2017-03-01/Test/Modules/zsh/db/gdbm.so: cannot open shared object file: No such file or directory
>>>> 4 /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: skipped (can't load zsh/db/gdbm module for testing)
Personally I think it'd be good to hide that particular
error message; line 4 tells the user what he needs to know.
CHeers,
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Skipping gdbm test
2017-03-03 9:55 ` Daniel Shahaf
@ 2017-03-03 10:14 ` Peter Stephenson
0 siblings, 0 replies; 6+ messages in thread
From: Peter Stephenson @ 2017-03-03 10:14 UTC (permalink / raw)
To: zsh-workers
On Fri, 3 Mar 2017 09:55:15 +0000
Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> I think the proposal was to removal lines 2,3 but keep lines 1,4:
>
> >>>> 1 /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: starting.
> >>>> 2 (eval):3: failed to load module `zsh/db/gdbm':
> >>>> 3 /opt/build/zsh-2017-03-01/Test/Modules/zsh/db/gdbm.so: cannot open shared object file: No such file or directory
> >>>> 4 /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: skipped (can't load zsh/db/gdbm module for testing)
>
> Personally I think it'd be good to hide that particular
> error message; line 4 tells the user what he needs to know.
Oh, yes, we don't need the shell error message, since it's not a hard
test error. The skipped message from the test system is enough. This
is how various of the other module tests work.
pws
diff --git a/Test/V11db_gdbm.ztst b/Test/V11db_gdbm.ztst
index 486ad48..1d80f28 100644
--- a/Test/V11db_gdbm.ztst
+++ b/Test/V11db_gdbm.ztst
@@ -4,7 +4,7 @@
modname="zsh/db/gdbm"
dbfile=db.gdbm
- if ! zmodload $modname ; then
+ if ! zmodload $modname 2>/dev/null; then
ZTST_unimplemented="can't load $modname module for testing"
fi
rm -f db.gdbm
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-03 10:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170302145932epcas5p18f7477866f38d8bbc75a640afffa04cd@epcas5p1.samsung.com>
2017-03-01 19:41 ` Skipping gdbm test Vin Shelton
2017-03-02 15:05 ` Peter Stephenson
2017-03-02 16:17 ` Sebastian Gniazdowski
2017-03-03 9:19 ` Peter Stephenson
2017-03-03 9:55 ` Daniel Shahaf
2017-03-03 10:14 ` Peter Stephenson
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).