Re: [PATCH] Remove _stgit completion script

[Daniel Shahaf <d.s@daniel.shahaf.name>]

Peter Grayson wrote on Tue, Oct 25, 2022 at 16:43:21 -0400:
> The StGit project ships its own zsh completion script which is more
> complete and up-to-date than those shipped with zsh.
> 
> https://github.com/stacked-git/stgit/blob/master/completion/stgit.zsh
> 

+ I see that completion script gets updated in lockstep with stg(1)'s
  argv parser.

+ Given the two projects' release schedules it seems safe to assume that
  by zsh's next release stg 2.0 will have been released as well, so most
  users won't end up in a situation where they have neither _stgit nor
  stgit.zsh. 

+ No objections in a week.

- _stgit and stgit.zsh are licenced differently.

Being licenced under the same terms as zsh itself seems to be outweighed
by not being regularly updated.  So, I've pushed this.  The last version
is of course still available in our version control history.

> Also, the _stgit completions that ship with zsh, which dynamically parse
> StGit's help output, will be broken by the upcoming StGit 2.0 release
> due to changes in the help output.
> 

StGit is also used by vcs_info, here:

https://github.com/zsh-users/zsh/blob/b76dcecfe3461aa9a9e29dffe2484f097611f9ff/Functions/VCS_Info/Backends/VCS_INFO_get_data_git#L187-L194

(There doesn't seem to be StGit-specific code elsewhere in the file or
in the sibling file VCS_INFO_detect_git.)

Any chance that someone who uses both StGit and zsh could review that?
That code is supposed to populate $gitmisc (and thus the %m expando)
with information about pushed and not-yet-pushed patches.

To test that:

[[[
autoload vcs_info
precmd() { vcs_info }
zstyle ':vcs_info:*' formats %m
zstyle ':vcs_info:*' actionformats %m
]]]

> Signed-off-by: Peter Grayson <pete@jpgrayson.net>
> ---
> 
> N.B. I am the StGit maintainer and primary author of StGit's zsh
> completion script.
> 

Welcome :-)

Cheers,

Daniel

>  Completion/Unix/Command/_stgit | 52 ----------------------------------
>  1 file changed, 52 deletions(-)
>  delete mode 100644 Completion/Unix/Command/_stgit
> 
> diff --git a/Completion/Unix/Command/_stgit b/Completion/Unix/Command/_stgit
> deleted file mode 100644
> index e31af460a..000000000
> --- a/Completion/Unix/Command/_stgit
> +++ /dev/null
> @@ -1,52 +0,0 @@
> -#compdef stg
⋮
> -return ret