zsh-workers
 help / color / mirror / code / Atom feed
From: "Lawrence Velázquez" <larryv@zsh.org>
To: "Marlon Richert" <marlon.richert@gmail.com>,
	"Bart Schaefer" <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: Let run-help filter cmd_args before calling run-help-<command> (was Re: [RFC][PATCH] Try calling command with help flags in run-help)
Date: Thu, 03 Jun 2021 17:45:29 -0400	[thread overview]
Message-ID: <9b5f772f-2af3-4c9e-a83f-6c6f4496c6be@www.fastmail.com> (raw)
In-Reply-To: <CAHLkEDuPgBaNoGyu-io=0HKB1FxOpHGoHYUXHQSrwztMuEMVAw@mail.gmail.com>

On Thu, Jun 3, 2021, at 5:26 PM, Marlon Richert wrote:
> On Thu, Jun 3, 2021 at 7:34 AM Bart Schaefer <schaefer@brasslantern.com> wrote:
> > Stupid example, but:
> >
> > % ssh -- localhost date
> >
> > Without the patch, run-help displays help for the "date" command.
> > With it, help for "ssh".
> 
> That's weird. For me, it gets help for 'ssh', both before and after
> the patch (on commit bd328a2).

Same for me, on the 5.8 release.

> > or some commands that have git-style sub-commands.
> 
> My patch actually fixes an annoying case with 'run-help git'. Try
> pressing ^[h on, for example, 'git -C /path/to/zsh log'. Without my
> patch, it gives
> 
> % run-help git
> git is /usr/bin/git
> error: invalid key: alias.-C
> No manual entry for git--C
> 
> With my patch, it correctly displays help for 'git log'.

This already works correctly for me on the 5.8 release, but I don't
have any zsh or git aliases configured.

-- 
vq


  reply	other threads:[~2021-06-03 21:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 20:47 [RFC][PATCH] Try calling command with help flags in run-help Marlon Richert
2021-05-25 20:57 ` Bart Schaefer
2021-06-02 18:26   ` [PATCH] Let run-help try to show function source from file (was Re: [RFC][PATCH] Try calling command with help flags in run-help) Marlon Richert
2021-06-20 21:23     ` Lawrence Velázquez
2021-07-18 18:38       ` Lawrence Velázquez
2021-07-28  2:03       ` Bart Schaefer
2021-06-02 20:58   ` Let run-help filter cmd_args before calling run-help-<command> " Marlon Richert
2021-06-03  4:34     ` Bart Schaefer
2021-06-03  4:38       ` Bart Schaefer
2021-06-03 21:26       ` Marlon Richert
2021-06-03 21:45         ` Lawrence Velázquez [this message]
2021-06-03 21:52           ` Bart Schaefer
2021-06-03 22:00             ` Lawrence Velázquez
2021-06-03 23:33         ` Bart Schaefer
2021-06-05 19:15           ` Marlon Richert
2021-06-20 18:01             ` Lawrence Velázquez
2021-07-18 18:45               ` Lawrence Velázquez
2021-07-28 17:58                 ` Bart Schaefer
2021-07-29 12:11                   ` Marlon Richert
2021-07-30 16:55                     ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b5f772f-2af3-4c9e-a83f-6c6f4496c6be@www.fastmail.com \
    --to=larryv@zsh.org \
    --cc=marlon.richert@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).