From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Let run-help filter cmd_args before calling run-help-<command> (was Re: [RFC][PATCH] Try calling command with help flags in run-help)
Date: Thu, 3 Jun 2021 16:33:04 -0700 [thread overview]
Message-ID: <CAH+w=7YVoGkNVETdPJkqDNGM8aN16=RL_yiUOWReX9DsJG-vNA@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDuPgBaNoGyu-io=0HKB1FxOpHGoHYUXHQSrwztMuEMVAw@mail.gmail.com>
On Thu, Jun 3, 2021 at 2:27 PM Marlon Richert <marlon.richert@gmail.com> wrote:
>
> On Thu, Jun 3, 2021 at 7:34 AM Bart Schaefer <schaefer@brasslantern.com> wrote:
> > Stupid example, but:
> >
> > % ssh -- localhost date
> >
> > Without the patch, run-help displays help for the "date" command.
> > With it, help for "ssh".
>
> That's weird. For me, it gets help for 'ssh', both before and after
> the patch (on commit bd328a2).
As mentioned elsewhere, you do have to manually load run-help-ssh into
your test shell, it is not an autoloadable file.
> My patch actually fixes an annoying case with 'run-help git'. Try
> pressing ^[h on, for example, 'git -C /path/to/zsh log'.
This works for me, with or without your patch, using the git
completion in the current repository head. Are you sure you're
loading functions from the right path?
> Anyway, here's a new version of my patch. Let me know what you think.
I don't see any obvious problems with it but I don't know how to
construct a test case for any of the helpers you've edited. It would
be nice to know that this does not break the un-edited versions of
those helpers, because if those changes are required rather than just
redundant code removal, other helpers in the wild would also require
editing.
next prev parent reply other threads:[~2021-06-03 23:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 20:47 [RFC][PATCH] Try calling command with help flags in run-help Marlon Richert
2021-05-25 20:57 ` Bart Schaefer
2021-06-02 18:26 ` [PATCH] Let run-help try to show function source from file (was Re: [RFC][PATCH] Try calling command with help flags in run-help) Marlon Richert
2021-06-20 21:23 ` Lawrence Velázquez
2021-07-18 18:38 ` Lawrence Velázquez
2021-07-28 2:03 ` Bart Schaefer
2021-06-02 20:58 ` Let run-help filter cmd_args before calling run-help-<command> " Marlon Richert
2021-06-03 4:34 ` Bart Schaefer
2021-06-03 4:38 ` Bart Schaefer
2021-06-03 21:26 ` Marlon Richert
2021-06-03 21:45 ` Lawrence Velázquez
2021-06-03 21:52 ` Bart Schaefer
2021-06-03 22:00 ` Lawrence Velázquez
2021-06-03 23:33 ` Bart Schaefer [this message]
2021-06-05 19:15 ` Marlon Richert
2021-06-20 18:01 ` Lawrence Velázquez
2021-07-18 18:45 ` Lawrence Velázquez
2021-07-28 17:58 ` Bart Schaefer
2021-07-29 12:11 ` Marlon Richert
2021-07-30 16:55 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YVoGkNVETdPJkqDNGM8aN16=RL_yiUOWReX9DsJG-vNA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).