From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Let run-help filter cmd_args before calling run-help-<command> (was Re: [RFC][PATCH] Try calling command with help flags in run-help)
Date: Wed, 2 Jun 2021 21:34:42 -0700 [thread overview]
Message-ID: <CAH+w=7YZVzbKde3NOaDxYSzJRwyWRTLc=RHOX4XATSBOT=Tvcw@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDvhcTi-q-yKiwYAhyuSWTjB-mof0RCKqWyhmFrFQjPOsA@mail.gmail.com>
On Wed, Jun 2, 2021 at 1:58 PM Marlon Richert <marlon.richert@gmail.com> wrote:
>
> And here's another part of workers 48926 as a separate patch.
run-help:115: parse error near `]'
Typo?
+ shift -p (( $#cmd_args + 1 - cmd_args[(i)(-|--|;)] )) cmd_args
This change also breaks the run-help-ssh example in the documentation,
and does so in a way I think it's impossible to fix.
Stupid example, but:
% ssh -- localhost date
Without the patch, run-help displays help for the "date" command.
With it, help for "ssh".
It would not surprise me to find that attempting to generically parse
arguments in run-help would also break helpers for commands like "su"
and "sudo", some commands that have git-style sub-commands, or .
next prev parent reply other threads:[~2021-06-03 4:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 20:47 [RFC][PATCH] Try calling command with help flags in run-help Marlon Richert
2021-05-25 20:57 ` Bart Schaefer
2021-06-02 18:26 ` [PATCH] Let run-help try to show function source from file (was Re: [RFC][PATCH] Try calling command with help flags in run-help) Marlon Richert
2021-06-20 21:23 ` Lawrence Velázquez
2021-07-18 18:38 ` Lawrence Velázquez
2021-07-28 2:03 ` Bart Schaefer
2021-06-02 20:58 ` Let run-help filter cmd_args before calling run-help-<command> " Marlon Richert
2021-06-03 4:34 ` Bart Schaefer [this message]
2021-06-03 4:38 ` Bart Schaefer
2021-06-03 21:26 ` Marlon Richert
2021-06-03 21:45 ` Lawrence Velázquez
2021-06-03 21:52 ` Bart Schaefer
2021-06-03 22:00 ` Lawrence Velázquez
2021-06-03 23:33 ` Bart Schaefer
2021-06-05 19:15 ` Marlon Richert
2021-06-20 18:01 ` Lawrence Velázquez
2021-07-18 18:45 ` Lawrence Velázquez
2021-07-28 17:58 ` Bart Schaefer
2021-07-29 12:11 ` Marlon Richert
2021-07-30 16:55 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YZVzbKde3NOaDxYSzJRwyWRTLc=RHOX4XATSBOT=Tvcw@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).