From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 2/3] Make dynamic dir completion easier to implement
Date: Sat, 13 May 2023 10:30:52 -0700 [thread overview]
Message-ID: <CAH+w=7YmSu8YGXTtXHK=F-jDqmB02aSXANT+Dfy=4evoGYs4sA@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7b5SEsgWi84xb0bUzEMB7y=uRV8YuiE8y08JjqAQCNZvA@mail.gmail.com>
On Sat, May 6, 2023 at 10:28 AM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> Not necessarily asking Marlon to do this, but if this patch is going
> to be included we need to repair these two functions:
>
> Functions/Chpwd/zsh_directory_name_cdr
> Functions/Chpwd/zsh_directory_name_generic
Attempting to extrapolate from Marlon's edits to the doc example, I
think the only part of these that really needs to change is the "if
completion" branch. However, I'm not a user of the "cdr" functions so
I'm not sure what to do with the former, or if the "Can't complete in
the middle" warning still applies in the latter (and if it does, is
that a problem with Marlon's patch?); nor if the explanatory text
passed to _describe in either function has to move somewhere.
next prev parent reply other threads:[~2023-05-13 17:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 18:07 Patch 1/3: Fix prefix insertion logic Marlon Richert
2023-04-29 18:08 ` Patch 2/3: Make dynamic dir completion easier to implement Marlon Richert
2023-04-29 18:09 ` Patch 3/3: Fix subscript completion bugs inside ~[...] Marlon Richert
2023-04-29 18:58 ` Patch 1/3: Fix prefix insertion logic Felipe Contreras
2023-04-29 19:02 ` Marlon Richert
2023-04-29 19:17 ` Bart Schaefer
2023-05-01 21:08 ` Aaron Schrab
2023-05-01 22:03 ` Bart Schaefer
2023-05-05 11:41 ` [PATCH 1/3] Fix _prefix " Marlon Richert
2023-06-07 6:03 ` Marlon Richert
2023-06-08 12:41 ` Jun. T
2023-06-15 14:11 ` Marlon Richert
2023-05-05 11:41 ` [PATCH 2/3] Make dynamic dir completion easier to implement Marlon Richert
2023-05-06 17:28 ` Bart Schaefer
2023-05-13 17:30 ` Bart Schaefer [this message]
2023-05-15 9:04 ` Oliver Kiddle
2023-05-05 11:41 ` [PATCH 3/3] Fix subscript completion bugs inside ~[...] Marlon Richert
2023-05-01 22:37 ` Patch 1/3: Fix prefix insertion logic Felipe Contreras
2023-05-01 22:52 ` Bart Schaefer
2023-05-02 4:49 ` Felipe Contreras
2023-05-02 19:16 ` Bart Schaefer
2023-05-02 20:14 ` Felipe Contreras
2023-05-05 11:51 ` Marlon Richert
2023-05-05 12:38 ` Felipe Contreras
2023-05-05 15:04 ` Mikael Magnusson
2023-05-06 17:23 ` Bart Schaefer
2023-05-01 23:36 ` Vin Shelton
2023-05-18 20:44 [PATCH 2/3] Make dynamic dir completion easier to implement Marlon Richert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YmSu8YGXTtXHK=F-jDqmB02aSXANT+Dfy=4evoGYs4sA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).