From: Marlon Richert <marlon.richert@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 1/3] Fix _prefix insertion logic
Date: Wed, 7 Jun 2023 09:03:09 +0300 [thread overview]
Message-ID: <CAHLkEDtPeQBvSzUvaqrq1wQLzAuJHMQLuFBGHzntwOaARUVnvg@mail.gmail.com> (raw)
In-Reply-To: <20230505114154.76547-1-marlonrichert@users.noreply.github.com>
On Fri, May 5, 2023 at 2:44 PM Marlon Richert <marlon.richert@gmail.com> wrote:
>
> This solves the following problems in the _prefix completer:
> - The old code had logic for dealing with compstate[unambiguous] that
> was unnecessary. It works fine without it.
> - Because of this logic, if a widget set compstate[insert]=1 after
> calling _main_complete, an `x` was left after the completion on the
> command line.
> - If the same widget also set `compstate[to_end]=`, then instead, the
> last character of the inserted completion would be treated as an
> autoremovable suffix, with the actual suffix being inserted to the
> line as a normal character.
> - After inserting a completion, the cursor would move to the end of the
> entire current word on the command, not the end of word that was
> inserted. This is not what you want with _prefix, since you are trying
> to complete a word _before_ the one on the command line, after which
> you usually want to insert a separator, such as a space or slash,
> before the next word.
>
> Discussed in workers/51641.
> ---
Any further comments on this patch? Will it be committed?
next prev parent reply other threads:[~2023-06-07 6:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 18:07 Patch 1/3: Fix prefix " Marlon Richert
2023-04-29 18:08 ` Patch 2/3: Make dynamic dir completion easier to implement Marlon Richert
2023-04-29 18:09 ` Patch 3/3: Fix subscript completion bugs inside ~[...] Marlon Richert
2023-04-29 18:58 ` Patch 1/3: Fix prefix insertion logic Felipe Contreras
2023-04-29 19:02 ` Marlon Richert
2023-04-29 19:17 ` Bart Schaefer
2023-05-01 21:08 ` Aaron Schrab
2023-05-01 22:03 ` Bart Schaefer
2023-05-05 11:41 ` [PATCH 1/3] Fix _prefix " Marlon Richert
2023-06-07 6:03 ` Marlon Richert [this message]
2023-06-08 12:41 ` Jun. T
2023-06-15 14:11 ` Marlon Richert
2023-05-05 11:41 ` [PATCH 2/3] Make dynamic dir completion easier to implement Marlon Richert
2023-05-06 17:28 ` Bart Schaefer
2023-05-13 17:30 ` Bart Schaefer
2023-05-15 9:04 ` Oliver Kiddle
2023-05-05 11:41 ` [PATCH 3/3] Fix subscript completion bugs inside ~[...] Marlon Richert
2023-05-01 22:37 ` Patch 1/3: Fix prefix insertion logic Felipe Contreras
2023-05-01 22:52 ` Bart Schaefer
2023-05-02 4:49 ` Felipe Contreras
2023-05-02 19:16 ` Bart Schaefer
2023-05-02 20:14 ` Felipe Contreras
2023-05-05 11:51 ` Marlon Richert
2023-05-05 12:38 ` Felipe Contreras
2023-05-05 15:04 ` Mikael Magnusson
2023-05-06 17:23 ` Bart Schaefer
2023-05-01 23:36 ` Vin Shelton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLkEDtPeQBvSzUvaqrq1wQLzAuJHMQLuFBGHzntwOaARUVnvg@mail.gmail.com \
--to=marlon.richert@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).