From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Patch 1/3: Fix prefix insertion logic
Date: Mon, 1 May 2023 15:03:25 -0700 [thread overview]
Message-ID: <CAH+w=7aWEesO_hN+eUCj9VCJ+soUvXqSSNRAAPSY-JoCZvcWcQ@mail.gmail.com> (raw)
In-Reply-To: <20230501T210812Z.-CT1GOihZPID@pug.qqx.org>
On Mon, May 1, 2023 at 2:10 PM Aaron Schrab <aaron@schrab.com> wrote:
>
> I certainly don't find "Fix prefix insertion logic" to be a very helpful
> commit message. It might be a decent subject, but I'd expect the full
> message to give at least *some* idea of what the problem is.
Yes, if this connects back to an earlier thread ("Why is an 'x'
appended ..." maybe?) then some reference to that should be made.
> The second patch in the series had a subject that I'd consider slightly
> more useful ("Make dynamic dir completion easier to implement"), but I'd
> generally expect the description to give some idea of how it makes
> implementation easier.
Also, easier for whom? If the end user, I'd expect some sort of doc
change, or at least a reference to what's currently difficult.
> The final patch of the series does appear to have a decent message,
> although I haven't attempted to check how it lines up with the actual
> patch.
This one looks OK, the included test cases appear to exemplify the issue.
next prev parent reply other threads:[~2023-05-01 22:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 18:07 Marlon Richert
2023-04-29 18:08 ` Patch 2/3: Make dynamic dir completion easier to implement Marlon Richert
2023-04-29 18:09 ` Patch 3/3: Fix subscript completion bugs inside ~[...] Marlon Richert
2023-04-29 18:58 ` Patch 1/3: Fix prefix insertion logic Felipe Contreras
2023-04-29 19:02 ` Marlon Richert
2023-04-29 19:17 ` Bart Schaefer
2023-05-01 21:08 ` Aaron Schrab
2023-05-01 22:03 ` Bart Schaefer [this message]
2023-05-05 11:41 ` [PATCH 1/3] Fix _prefix " Marlon Richert
2023-06-07 6:03 ` Marlon Richert
2023-06-08 12:41 ` Jun. T
2023-06-15 14:11 ` Marlon Richert
2023-05-05 11:41 ` [PATCH 2/3] Make dynamic dir completion easier to implement Marlon Richert
2023-05-06 17:28 ` Bart Schaefer
2023-05-13 17:30 ` Bart Schaefer
2023-05-15 9:04 ` Oliver Kiddle
2023-05-05 11:41 ` [PATCH 3/3] Fix subscript completion bugs inside ~[...] Marlon Richert
2023-05-01 22:37 ` Patch 1/3: Fix prefix insertion logic Felipe Contreras
2023-05-01 22:52 ` Bart Schaefer
2023-05-02 4:49 ` Felipe Contreras
2023-05-02 19:16 ` Bart Schaefer
2023-05-02 20:14 ` Felipe Contreras
2023-05-05 11:51 ` Marlon Richert
2023-05-05 12:38 ` Felipe Contreras
2023-05-05 15:04 ` Mikael Magnusson
2023-05-06 17:23 ` Bart Schaefer
2023-05-01 23:36 ` Vin Shelton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7aWEesO_hN+eUCj9VCJ+soUvXqSSNRAAPSY-JoCZvcWcQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=felipe.contreras@gmail.com \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).