Re: Patch 1/3: Fix prefix insertion logic

[Aaron Schrab <aaron@schrab.com>]

At 22:02 +0300 29 Apr 2023, Marlon Richert <marlon.richert@gmail.com> wrote:
>On Sat, Apr 29, 2023 at 9:58 PM Felipe Contreras
><felipe.contreras@gmail.com> wrote:
>> On Sat, Apr 29, 2023 at 1:09 PM Marlon Richert <marlon.richert@gmail.com> wrote:
>> I don't know what's zsh's policy regarding sending patches, but
>> personally I can't review zero content mails.
>
>Looks fine to me on the mailing list archives:
>https://www.zsh.org/mla/workers/2023/msg00409.html
>
>Should I copy-paste the commit message into the email's body next time?
>Would that help?

For the 1/3 and 2/3 there wasn't really a commit message other than the 
subject, the only content other than the patch itself was the git 
pseudo-header and stats about the files modified.

I certainly don't find "Fix prefix insertion logic" to be a very helpful 
commit message. It might be a decent subject, but I'd expect the full 
message to give at least *some* idea of what the problem is.

The second patch in the series had a subject that I'd consider slightly 
more useful ("Make dynamic dir completion easier to implement"), but I'd 
generally expect the description to give some idea of how it makes 
implementation easier.

The final patch of the series does appear to have a decent message, 
although I haven't attempted to check how it lines up with the actual 
patch.