From: "Douglas A. Gwyn" <DAGwyn@null.net>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] grap retarded??
Date: Mon, 29 Oct 2007 10:10:30 +0000 [thread overview]
Message-ID: <4723108A.2FC11F49@null.net> (raw)
In-Reply-To: <56091BE8-6F06-45B8-AB4F-075051F4B57D@mac.com>
I found another bug, in Plan 9 "grap" source file print.c,
function "opentemp": if tfd is not NULL and also not stdout,
it gets fclose()d twice. I don't know whether that happens
to be benign on the Plan 9 implementation, but it can cause
problems when ported to other platforms.
Also in the same file, in the "print" function, if tfd is
stdout then stdout is fclose()d but later continues to be
used.
I'm not sure of the intent of this change from an earlier
version of "grap"; however, I suggest the following patches
to src/grap/print.c:
In print(), change the test to
if (tfd != stdout) {
if (tfd != NULL)
fclose(tfd); /* end the temp file */
tfd = stdout;
}
In opentemp(), delete the first occurrence of
if (tfd != NULL)
fclose(tfd);
prev parent reply other threads:[~2007-10-29 10:10 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 22:38 Pietro Gagliardi
2007-10-26 23:17 ` geoff
2007-10-26 23:22 ` Pietro Gagliardi
2007-10-27 2:51 ` [9fans] detecting spam arisawa
2007-10-27 3:16 ` Pietro Gagliardi
2007-10-27 4:38 ` [9fans] security erik quanstrom
2007-10-27 9:03 ` roger peppe
2007-10-27 10:04 ` arisawa
2007-10-27 12:48 ` Uriel
2007-10-27 14:54 ` erik quanstrom
2007-10-27 17:19 ` Tim Newsham
2007-10-27 19:18 ` erik quanstrom
2007-10-27 22:20 ` don bailey
2007-10-27 22:25 ` Pietro Gagliardi
2007-10-27 22:33 ` don bailey
2007-10-28 0:17 ` David Leimbach
2007-10-28 6:00 ` Skip Tavakkolian
2007-10-28 6:06 ` john
2007-10-28 8:32 ` Joel C. Salomon
2007-10-28 20:53 ` Charles Forsyth
2007-10-27 23:40 ` Skip Tavakkolian
2007-10-28 6:11 ` don bailey
2007-10-28 6:30 ` Skip Tavakkolian
2007-10-28 6:42 ` don bailey
2007-10-28 7:28 ` Skip Tavakkolian
2007-10-28 12:53 ` Pietro Gagliardi
2007-10-28 15:52 ` don bailey
2007-10-28 15:51 ` don bailey
2007-10-28 15:59 ` Iruata Souza
2007-10-28 16:30 ` don bailey
2007-10-28 17:14 ` Iruata Souza
2007-10-28 17:22 ` Gabriel Diaz
2007-10-28 17:44 ` Pietro Gagliardi
2007-10-28 20:37 ` Charles Forsyth
2007-10-28 16:10 ` erik quanstrom
2007-10-28 16:26 ` don bailey
2007-10-28 18:30 ` Skip Tavakkolian
2007-10-28 18:43 ` Uriel
2007-10-28 18:58 ` Iruata Souza
2007-10-28 22:48 ` arisawa
2007-10-28 23:29 ` Pietro Gagliardi
2007-10-29 2:30 ` Skip Tavakkolian
2007-10-27 9:00 ` [9fans] detecting spam roger peppe
2007-10-27 13:16 ` Pietro Gagliardi
2007-10-27 13:41 ` erik quanstrom
2007-10-27 13:43 ` Pietro Gagliardi
2007-10-27 14:04 ` Martin Neubauer
2007-10-29 10:10 ` [9fans] grap retarded?? Douglas A. Gwyn
2007-10-29 18:43 ` Pietro Gagliardi
2007-10-29 10:10 ` Douglas A. Gwyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4723108A.2FC11F49@null.net \
--to=dagwyn@null.net \
--cc=9fans@cse.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).