[9fans] Abaco: url parsing problem

[9fans] Abaco: url parsing problem

[pavlovetsky]

Abaco complains about malformed URL if it contains "pipe" symbol: "|".
Any suggestions about fix?

Re: [9fans] Abaco: url parsing problem

[Federico G. Benavento]

> Abaco complains about malformed URL if it contains "pipe" symbol: "|".

ok, I just tested it, webfs doesn't like '|' in urls

http://www.google.com/hola|chau: parseurl: malformed absolute path: /hola|chau

> Any suggestions about fix?

yes, see /sys/src/cmd/webfs/url.c , there must be some wrong #define in Retab

Federico G. Benavento

---
/bin/fortune:
/dev/rra13: !!counts may be wrong, RERUN chuck!

Re: [9fans] Abaco: url parsing problem

[Juan M. Mendez]

A possible workaround is to use the encoded chars for the "pipe" symbol.

For example:

http://www.google.com/hola%7Cchau

-- 
Fidonet: 2:345/432.2

Re: [9fans] Abaco: url parsing problem

[Lyndon Nerenberg]

On 2007-Dec-20, at 02:56 , Federico G. Benavento wrote:

> ok, I just tested it, webfs doesn't like '|' in urls

That's because a naked '|' isn't a valid character in a URL.  You have  
to percent-encode it (%7c).

Re: [9fans] Abaco: url parsing problem

[Juan M. Mendez]

On 20/12/2007, Lyndon Nerenberg <lyndon@orthanc.ca> wrote:
> On 2007-Dec-20, at 02:56 , Federico G. Benavento wrote:
>
> > ok, I just tested it, webfs doesn't like '|' in urls
>
> That's because a naked '|' isn't a valid character in a URL.  You have
> to percent-encode it (%7c).

Does webfs do the url parsing? or abaco before sending it to webfs, if so, maybe
the function can be fixed easily.

-- 
Fidonet: 2:345/432.2

Re: [9fans] Abaco: url parsing problem

[Federico G. Benavento]

> Does webfs do the url parsing? or abaco before sending it to webfs, if so, maybe
> the function can be fixed easily.

I guess, my urlencode is broken, I'll fix it later

thanks

Federico G. Benavento

---
/bin/fortune:
Even the simplest solution is bound to have something wrong with it.

Re: [9fans] Abaco: url parsing problem

[Uriel]

That is why somebody (cough) riped out the url parsing code from webfs
and put it into a library, and then updated abaco to use that
library... but we all know here code and effort duplication is good,
so never mind.

uriel

On Dec 20, 2007 4:27 PM, Federico G. Benavento <benavento@gmail.com> wrote:
> > Does webfs do the url parsing? or abaco before sending it to webfs, if so, maybe
> > the function can be fixed easily.
>
> I guess, my urlencode is broken, I'll fix it later
>
> thanks
>
> Federico G. Benavento
>
> ---
> /bin/fortune:
> Even the simplest solution is bound to have something wrong with it.
>
>

Re: [9fans] Abaco: url parsing problem

[Kernel Panic]

Uriel wrote:

>That is why somebody (cough) riped out the url parsing code from webfs
>and put it into a library, and then updated abaco to use that
>library... but we all know here code and effort duplication is good,
>so never mind.
>  
>
the browser needs to understand url-encoding anyway beacause he
he needs to touch the url (build absolute urls from relatives in context 
of the fetched
page). so having the lib in abaco is ok i think.

but maybe other stuff could gain from webfs *fixing* urls. maybe some 
rc-scripts where you
dont want to urlencode stuff first? for example you want to fetch a 
search-result page
and dont want to urlencode your concatenated search query before passing 
it to webfs?

makes that sense? ;-)

>uriel
>
>On Dec 20, 2007 4:27 PM, Federico G. Benavento <benavento@gmail.com> wrote:
>  
>
>>>Does webfs do the url parsing? or abaco before sending it to webfs, if so, maybe
>>>the function can be fixed easily.
>>>      
>>>
>>I guess, my urlencode is broken, I'll fix it later
>>
>>thanks
>>
>>Federico G. Benavento
>>
>>---
>>/bin/fortune:
>>    
>>
>>Even the simplest solution is bound to have something wrong with it.
>>    
>>
--
cinap

Re: [9fans] Abaco: url parsing problem

[Uriel]

On Dec 21, 2007 11:13 AM, Kernel Panic <cinap_lenrek@gmx.de> wrote:
> Uriel wrote:
>
> >That is why somebody (cough) riped out the url parsing code from webfs
> >and put it into a library, and then updated abaco to use that
> >library... but we all know here code and effort duplication is good,
> >so never mind.
> >
> >
> the browser needs to understand url-encoding anyway beacause he
> he needs to touch the url (build absolute urls from relatives in context
> of the fetched
> page). so having the lib in abaco is ok i think.

Lets not forget javascript and other such abominations.

And that is *precisely* why having two half broken sets of URL
parsing/manipulation code, one in webfs and one in abaco is so silly.
And why I factored out the url code in webfs and put it into a liburl,
and then modified abaco link against that instead of its own
simplistic and broken URL code.

The result has been on my sources/contrib dir for ages, why fgb has
not used it is beyond me.

uriel


> but maybe other stuff could gain from webfs *fixing* urls. maybe some
> rc-scripts where you
> dont want to urlencode stuff first? for example you want to fetch a
> search-result page
> and dont want to urlencode your concatenated search query before passing
> it to webfs?
>
> makes that sense? ;-)
>
>
> >uriel
> >
> >On Dec 20, 2007 4:27 PM, Federico G. Benavento <benavento@gmail.com> wrote:
> >
> >
> >>>Does webfs do the url parsing? or abaco before sending it to webfs, if so, maybe
> >>>the function can be fixed easily.
> >>>
> >>>
> >>I guess, my urlencode is broken, I'll fix it later
> >>
> >>thanks
> >>
> >>Federico G. Benavento
> >>
> >>---
> >>/bin/fortune:
> >>
> >>
> >>Even the simplest solution is bound to have something wrong with it.
> >>
> >>
> --
> cinap
>
>

Re: [9fans] Abaco: url parsing problem

[Juan M. Mendez]

On 21/12/2007, Uriel <uriel99@gmail.com> wrote:

> The result has been on my sources/contrib dir for ages, why fgb has
> not used it is beyond me.

I will have a look at the library, I had to "partially" implement one
for a web app
that needed to save some data into a database from a cgi. It can be useful
for me to see another implementation.

-- 
Fidonet: 2:345/432.2

Re: [9fans] Abaco: url parsing problem

[David Leimbach]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

On Dec 21, 2007 7:39 AM, Uriel <uriel99@gmail.com> wrote:

> That is why somebody (cough) riped out the url parsing code from webfs
> and put it into a library, and then updated abaco to use that
> library... but we all know here code and effort duplication is good,
> so never mind.
>
> uriel
>

One could argue that to the extreme.  I've already got windows?  Why do I
need another operating system?  I should be happy with my windows, and just
contribute to that community, that way, all my changes can be viewed and
used by my fellow windows users.

I mean, if you're going to be pedantic and silly about a concept, why not go
all the way?

Fragmentation of effort is bad in all cases, or it isn't bad in all cases.
 You can't have both categorically at the same time.

Dave

[-- Attachment #2: Type: text/html, Size: 1352 bytes --]

Re: [9fans] Abaco: url parsing problem

[Uriel]

If you are looking for obnoxiousness and silliness devoid of any
content I recommend you re-read what you just wrote.

Or you could go and write yet another broken and useless url parsing
implementation.

uriel

On Dec 21, 2007 11:35 AM, David Leimbach <leimy2k@gmail.com> wrote:
>
>
>
> On Dec 21, 2007 7:39 AM, Uriel <uriel99@gmail.com> wrote:
> > That is why somebody (cough) riped out the url parsing code from webfs
> > and put it into a library, and then updated abaco to use that
> > library... but we all know here code and effort duplication is good,
> > so never mind.
> >
> > uriel
> >
> >
> >
> >
>
> One could argue that to the extreme.  I've already got windows?  Why do I
> need another operating system?  I should be happy with my windows, and just
> contribute to that community, that way, all my changes can be viewed and
> used by my fellow windows users.
>
> I mean, if you're going to be pedantic and silly about a concept, why not go
> all the way?
>
> Fragmentation of effort is bad in all cases, or it isn't bad in all cases.
> You can't have both categorically at the same time.
>
> Dave
>

Re: [9fans] Abaco: url parsing problem

[roger peppe]

On Dec 21, 2007 4:43 PM, Uriel <uriel99@gmail.com> wrote:
> If you are looking for obnoxiousness and silliness devoid of any
> content I recommend you re-read what you just wrote.

what a joy to hear such genuine expression of the Christmas spirit!

Re: [9fans] Abaco: url parsing problem

[David Leimbach]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

On Dec 21, 2007 8:55 AM, roger peppe <rogpeppe@gmail.com> wrote:

> On Dec 21, 2007 4:43 PM, Uriel <uriel99@gmail.com> wrote:
> > If you are looking for obnoxiousness and silliness devoid of any
> > content I recommend you re-read what you just wrote.
>
> what a joy to hear such genuine expression of the Christmas spirit!
>

Since this thread is now sarcastic... let me give it a go:

Uriel, THANK YOU!  Oh you're so right!  I, and everyone else on this list,
should totally always do exactly what you want.  It is wrong of us to ignore
your awesome contributions such as an URL parsing library.

I can't believe how dumb people are to not see how valuable you truly are to
us!

MERRY CHRISTMAS!

[-- Attachment #2: Type: text/html, Size: 1199 bytes --]

Re: [9fans] Abaco: url parsing problem

[sqweek]

On Dec 22, 2007 2:08 AM, David Leimbach <leimy2k@gmail.com> wrote:
> Uriel, THANK YOU!  Oh you're so right!  I, and everyone else on this list,
> should totally always do exactly what you want.  It is wrong of us to ignore
> your awesome contributions such as an URL parsing library.

 The implication that Uriel entertains delusions of granduer is
baseless and ridiculous enough to shock me out of any intentions I
might have had to continue the sarcasm chain.
 I hope your next comment on the issue comes after identifying
something which is likely to be a problem in the future, spending some
time and effort on fixing it (since no one else has yet), witnessing
it bloom into a problem, finding that your work was entirely ignored,
and not feeling the least bit frustrated.
-sqweek

Re: [9fans] Abaco: url parsing problem

[Wes Kussmaul]

David Leimbach wrote:

> Fragmentation of effort is bad in all cases, or it isn't bad in all 
> cases.  You can't have both categorically at the same time.

Ken Olsen at DEC would often give the same assignment to two teams, then have a bakeoff. Typically one of the two 
resulting things would be a clear winner but would be further improved by ideas and pieces from the other.

Wes Kussmaul

--

The information contained in this electronic message and any attachments to this message are intended for the exclusive 
use of the addressee(s) and may contain confidential or privileged information. If you are not the intended recipient, 
please notify attorney Mort Hapless at Vulner, Exposed & Wideopen LLP immediately at either (781) 647-7178, or at 
ohoh@vulex.com, and destroy all copies of this message and any attachments. No, really. Really. Listen, we mean it! Hey, 
if you don’t stop reading that confidential stuff about our client you’re in big trouble. OK, we’re the ones in trouble 
but we’ll find a way to go after you, or at least we think we may be able to. Look, we’re begging you. Just click the 
delete button and move on to a message that concerns you, OK? Please?? We'll buy you lunch...

Identity is the Foundation of Security™. Let Authentrus (authentrus.com) ensure that only intended recipients receive 
your confidential messages.

Re: [9fans] Abaco: url parsing problem

[ron minnich]

On Dec 21, 2007 7:39 AM, Uriel <uriel99@gmail.com> wrote:
> That is why somebody (cough) riped out the url parsing code from webfs
> and put it into a library, and then updated abaco to use that
> library... but we all know here code and effort duplication is good,
> so never mind.

I'm too slow. What on earth are you talking about? You mean, fix webfs
to use some fixed parsing library? who fixed it in the first place?
Works for me. So you're submitting a patch?

ron

[9fans] Re: Abaco: url parsing problem

[pavlovetsky]

Yes, if I substitute manually pipe symbol with ¨%7C¨ in URL, Abaco
takes this input as legitimate and it loads the corresponding page.
Maybe it makes sense to put small runtime substitution routine in the
Abaco code, so it will handle similar special characters as well.
Followup-To:
Distribution:
Organization: University of Bath Computing Services, UK
Keywords:
Cc:


--
Dennis Davis, BUCS, University of Bath, Bath, BA2 7AY, UK
D.H.Davis@bath.ac.uk