From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin
Date: Sat, 11 Jan 2020 20:15:49 +0000 [thread overview]
Message-ID: <20200111201549.GA1264@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <087AE8B9-35B0-4258-9626-AACA85471A07@kba.biglobe.ne.jp>
Jun T wrote on Fri, Jan 10, 2020 at 19:24:49 +0900:
>
> > 2020/01/09 22:15, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >
> > Yeah, the C preprocessor can't discover RLIMIT_* macros we don't know about in
> > advance, I agree. For that we'd need awk(1) or similar (maybe just «grep -o
> > 'RLIMIT_[^ ]*'»). Maybe something along these lines:
>
> Thanks.
> But I've started thinking that we can just use a resource name such as
> "unknown8" (instead of "FOO") for unknown resource. Then rlimits.awk can
> be removed as you have suggested originally.
>
> Of cause there is a chance that the tail part of the macro name ("FOO") may
> give some hint for users, but it is far from satisfactory anyway.
> If users find "unknown8" in the output of the limit builtin, then *hopefully*
> they report it to zsh/workers; then we can add it to the list of known
> resources easily.
I've thought about it and I think I agree. There could be RLIMIT_* macros that
aren't valid as arguments to getrlimit(2); assuming otherwise is a bit too
hacky, and the alternative — the limit being settable numerically — isn't that
bad.
We could even add a test that runs «ulimit -a | grep '^-N'» and, if that has
any output, prints a warning to stderr (without failing the test run).
The part that's not clear to me is how we'd even know that «8» is a valid value for
the first actual argument to getrlimit(). Currently, the code assumes that the
values of RLIMIT_* macros are consecutive small integers, but that is not guaranteed
by any standard, is it?
Cheers,
Daniel
next prev parent reply other threads:[~2020-01-11 20:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 10:39 Jun T
2020-01-08 21:33 ` Daniel Shahaf
2020-01-09 10:32 ` Jun T
2020-01-09 13:15 ` Daniel Shahaf
2020-01-10 10:24 ` Jun T
2020-01-11 20:15 ` Daniel Shahaf [this message]
2020-01-13 11:00 ` Jun T
2020-01-13 16:42 ` Daniel Shahaf
2020-01-14 4:44 ` Jun T
2020-01-14 16:25 ` Daniel Shahaf
2020-02-25 9:38 ` Jun T
2020-02-27 13:22 ` Daniel Shahaf
2020-02-27 18:46 ` Mikael Magnusson
2020-02-28 8:42 ` Jun T
2020-02-28 14:19 ` Daniel Shahaf
2020-02-28 14:31 ` Daniel Shahaf
2020-03-03 9:23 ` Jun T
2020-03-04 19:29 ` Daniel Shahaf
2020-03-05 10:26 ` Jun T
2020-03-05 14:58 ` Daniel Shahaf
2020-03-20 17:02 ` Daniel Shahaf
2020-03-20 17:20 ` Bart Schaefer
2020-03-20 17:39 ` Daniel Shahaf
2020-03-20 18:28 ` Daniel Shahaf
2020-03-20 18:36 ` Bart Schaefer
2020-03-20 19:38 ` Daniel Shahaf
2020-03-20 18:39 ` Bart Schaefer
2020-03-20 19:32 ` Daniel Shahaf
2020-03-20 19:18 ` Daniel Shahaf
2020-03-23 5:31 ` Jun T
2020-03-24 2:08 ` Daniel Shahaf
2020-03-23 5:41 ` Jun T
2020-03-24 1:33 ` Jun T
2020-03-24 2:43 ` Daniel Shahaf
2020-03-25 0:16 ` Jun T
2020-03-25 22:04 ` Daniel Shahaf
2020-03-25 23:42 ` [PATCH] find RLIM_NLIMITS correctly on CygwinjL Daniel Shahaf
2020-03-24 2:34 ` [PATCH] find RLIM_NLIMITS correctly on Cygwin Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200111201549.GA1264@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).