From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Jun T <takimoto-j@kba.biglobe.ne.jp>,
"zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin
Date: Fri, 20 Mar 2020 18:28:15 +0000 [thread overview]
Message-ID: <20200320182815.47adbec3@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20200320173908.3f017688@tarpaulin.shahaf.local2>
Daniel Shahaf wrote on Fri, 20 Mar 2020 17:39 +0000:
> Bart Schaefer wrote on Fri, 20 Mar 2020 10:20 -0700:
> > On Fri, Mar 20, 2020 at 10:03 AM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > >
> > > The "limit" builtin is provided by a module. As such, it can be
> > > unavailable if the module had been disabled in config.modules prior to
> > > building.
> > >
> > > Proposed patch:
> > >
> > > + if grep '^name=zsh/rlimits .* link=no ' $ZTST_testdir/../config.modules >/dev/null
> >
> > Wouldn't it be better to test this with "zmodload" rather than attempt
> > to examine the build config?
>
> That was my first instinct too, but I just copied what V07pcre.ztst
> did. If using zmodload is better, then that file should probably be
> updated to that approach too.
Ah, I see. I think the reason for checking config.modules is because
we need to distinguish between "module had been disabled" and "module
was enabled, but failed to load due to a bug". That is, we want the
test suite to fail if the module failed to load even though it was
enabled in config.modules.
However, most Test/V*.ztst files use a simple «if ! zmodload zsh/foo; …»
check.
So, I think we should write a ZTST_* helper function that encapsulates
the config.modules check, and then call it as «ZTST_load_or_skip zsh/foo || return $?»
to make sure that V${N}foo.ztst fails if «zmodload zsh/foo» unexpectedly failed.
Makes sense?
Cheers,
Daniel
next prev parent reply other threads:[~2020-03-20 18:29 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 10:39 Jun T
2020-01-08 21:33 ` Daniel Shahaf
2020-01-09 10:32 ` Jun T
2020-01-09 13:15 ` Daniel Shahaf
2020-01-10 10:24 ` Jun T
2020-01-11 20:15 ` Daniel Shahaf
2020-01-13 11:00 ` Jun T
2020-01-13 16:42 ` Daniel Shahaf
2020-01-14 4:44 ` Jun T
2020-01-14 16:25 ` Daniel Shahaf
2020-02-25 9:38 ` Jun T
2020-02-27 13:22 ` Daniel Shahaf
2020-02-27 18:46 ` Mikael Magnusson
2020-02-28 8:42 ` Jun T
2020-02-28 14:19 ` Daniel Shahaf
2020-02-28 14:31 ` Daniel Shahaf
2020-03-03 9:23 ` Jun T
2020-03-04 19:29 ` Daniel Shahaf
2020-03-05 10:26 ` Jun T
2020-03-05 14:58 ` Daniel Shahaf
2020-03-20 17:02 ` Daniel Shahaf
2020-03-20 17:20 ` Bart Schaefer
2020-03-20 17:39 ` Daniel Shahaf
2020-03-20 18:28 ` Daniel Shahaf [this message]
2020-03-20 18:36 ` Bart Schaefer
2020-03-20 19:38 ` Daniel Shahaf
2020-03-20 18:39 ` Bart Schaefer
2020-03-20 19:32 ` Daniel Shahaf
2020-03-20 19:18 ` Daniel Shahaf
2020-03-23 5:31 ` Jun T
2020-03-24 2:08 ` Daniel Shahaf
2020-03-23 5:41 ` Jun T
2020-03-24 1:33 ` Jun T
2020-03-24 2:43 ` Daniel Shahaf
2020-03-25 0:16 ` Jun T
2020-03-25 22:04 ` Daniel Shahaf
2020-03-25 23:42 ` [PATCH] find RLIM_NLIMITS correctly on CygwinjL Daniel Shahaf
2020-03-24 2:34 ` [PATCH] find RLIM_NLIMITS correctly on Cygwin Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320182815.47adbec3@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=schaefer@brasslantern.com \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).