help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: dana <dana@dana.is>
Cc: Zsh hackers list <zsh-workers@zsh.org>,
	Peter Stephenson <p.w.stephenson@ntlworld.com>
Subject: Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
Date: Mon, 17 Jul 2023 08:17:12 -0700	[thread overview]
Message-ID: <CAH+w=7a04Xv7sGMBuDmBTY2Vw8Jb9q=OMgg6mRs-E8ThQzCwTw@mail.gmail.com> (raw)
In-Reply-To: <974250f6-d143-4543-872e-05c72f67a98c@app.fastmail.com>

On Sun, Jul 16, 2023 at 3:29 AM dana <dana@dana.is> wrote:
> On Tue 17 Jan 2023, at 12:00, Bart Schaefer wrote:
> > My concern is that the Thingy pointer becomes invalid
> I think this was justified
> I've just tried running a new HEAD build for the first time in several months
> and found that back-spacing causes the shell to crash.

The patch from the start of this thread has never been committed, so
is not directly related.  That is, if the Thingy is invalid, it's not
$LASTWIDGET that's making the bad reference here, so fixing
save/restore there probably will not resolve the problem.

In your backtrace I see
followed by
and finally
causes the actual crash below unrefthingy(), so I suspect this is a
reference-counting problem.

  parent reply	other threads:[~2023-07-17 15:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 15:06 Marlon Richert
2022-11-16 18:24 ` Bart Schaefer
2022-11-17 13:04   ` Marlon Richert
2022-11-17 13:28     ` Roman Perepelitsa
2022-11-17 16:18     ` Bart Schaefer
2023-01-11  7:45       ` Marlon Richert
2023-01-17  0:01 ` [PATCH] " Bart Schaefer
2023-01-17  9:22   ` Peter Stephenson
2023-01-17 18:00     ` Bart Schaefer
2023-07-16 10:28       ` dana
2023-07-17  8:42         ` Peter Stephenson
2023-07-17 15:17         ` Bart Schaefer [this message]
2023-07-17 15:52           ` dana
2023-07-17 15:57             ` Bart Schaefer
2023-07-17 16:57               ` Bart Schaefer
2023-07-20  4:01                 ` dana
2023-07-20  4:25                   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7a04Xv7sGMBuDmBTY2Vw8Jb9q=OMgg6mRs-E8ThQzCwTw@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=dana@dana.is \
    --cc=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).