help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: "Bart Schaefer" <schaefer@brasslantern.com>
Cc: "Zsh hackers list" <zsh-workers@zsh.org>,
	"Peter Stephenson" <p.w.stephenson@ntlworld.com>
Subject: Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
Date: Mon, 17 Jul 2023 10:52:01 -0500	[thread overview]
Message-ID: <f9c563ef-1414-44d9-ad21-377ff9529531@app.fastmail.com> (raw)
In-Reply-To: <CAH+w=7a04Xv7sGMBuDmBTY2Vw8Jb9q=OMgg6mRs-E8ThQzCwTw@mail.gmail.com>

On Mon 17 Jul 2023, at 10:17, Bart Schaefer wrote:
> The patch from the start of this thread has never been committed, so
> is not directly related.  That is, if the Thingy is invalid, it's not
> $LASTWIDGET that's making the bad reference here, so fixing
> save/restore there probably will not resolve the problem.

Sorry, i'm not very familiar with the LASTWIDGET mechanism, but by the patch
at the start of this thread you mean workers/51310, right? It was committed
as f93ad02b94bd

I should have mentioned that i did a (manual) bisect to confirm that that is
when the problem started for me; the poster in workers/51673 found the same,
with what sounds like a very similar configuration (though they didn't
provide any other details). I can't get the problem to occur on a build off
the preceding commit or on the 5.9 release

I did examine the functions the trace references before; the
_zsh_highlight_widget_orig... one simply calls _zsh_highlight_call_widget,
and that one calls zle before calling another highlight function (but the
crash happens in zle so it's not getting to that). The autosuggest ones are a
little more elaborate. I can get back to it later


  reply	other threads:[~2023-07-17 15:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 15:06 Marlon Richert
2022-11-16 18:24 ` Bart Schaefer
2022-11-17 13:04   ` Marlon Richert
2022-11-17 13:28     ` Roman Perepelitsa
2022-11-17 16:18     ` Bart Schaefer
2023-01-11  7:45       ` Marlon Richert
2023-01-17  0:01 ` [PATCH] " Bart Schaefer
2023-01-17  9:22   ` Peter Stephenson
2023-01-17 18:00     ` Bart Schaefer
2023-07-16 10:28       ` dana
2023-07-17  8:42         ` Peter Stephenson
2023-07-17 15:17         ` Bart Schaefer
2023-07-17 15:52           ` dana [this message]
2023-07-17 15:57             ` Bart Schaefer
2023-07-17 16:57               ` Bart Schaefer
2023-07-20  4:01                 ` dana
2023-07-20  4:25                   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9c563ef-1414-44d9-ad21-377ff9529531@app.fastmail.com \
    --to=dana@dana.is \
    --cc=p.w.stephenson@ntlworld.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).