From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] initialization of main keymap
Date: Fri, 2 Sep 2022 08:51:10 +0000 [thread overview]
Message-ID: <20220902085110.GE5920@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAMP44s2Cz8otHnHiKnknKODioUC-S=oNYPm6c6TFgMb5JgQySg@mail.gmail.com>
Felipe Contreras wrote on Thu, Sep 01, 2022 at 16:58:05 -0500:
> most vim users use emacs key bindings in the shell.
Citation needed.
> In my opinion the default should always be emacs bindings, no matter what.
+1
If the default were /either/ vi or emacs, a patch making the default
depend on the value of $EDITOR would never have been accepted. We'd
have pointed out that it was overloading an environment variable that
already has a well-defined meaning; that a dependency between that
envvar and zle violates the principle of least surprise; that assuming
strstr(…, "vi") means "Vi-like editor" is guesswork (cf. PEP20); that
the C code shouldn't presume Vi users necessarily prefer «bindkey -v»;
and that users can and should set their preferred Zsh Line Editor keymap
in zshrc.
Attached is a counterpatch for discussion.
Felipe: Should revisions to this patch be requested, feel free to beat
me to implementing them, if you wish.
Cheers,
Daniel
[[[
diff --git a/README b/README
index 21142e17c..f4821e0e1 100644
--- a/README
+++ b/README
@@ -31,6 +31,28 @@ Zsh is a shell with lots of features. For a list of some of these, see the
file FEATURES, and for the latest changes see NEWS. For more
details, see the documentation.
+Incompatibilities since 5.9
+---------------------------
+
+The line editor's default keymap is now the "emacs" keymap regardless of the
+value of the environment variables $VISUAL and $EDITOR. This only affects you
+if your $VISUAL or $EDITOR environment variable is set to a value that
+contains the string "vi". To get the previous behaviour, add
+.
+ bindkey -v
+.
+or, if your $VISUAL and $EDITOR environment variables vary,
+.
+ if [[ ${VISUAL:-${EDITOR:-emacs}} == *vi* ]]; then
+ bindkey -v
+ else
+ bindkey -e
+ fi
+.
+to your .zshrc file. These snippets are compatible with previous
+versions of the shell.
+
Incompatibilities since 5.8.1
-----------------------------
diff --git a/Src/Zle/zle_keymap.c b/Src/Zle/zle_keymap.c
index d90838f03..67a5351fd 100644
--- a/Src/Zle/zle_keymap.c
+++ b/Src/Zle/zle_keymap.c
@@ -1445,20 +1445,14 @@ default_bindings(void)
}
/* Put the keymaps in the right namespace. The "main" keymap *
- * will be linked to the "emacs" keymap, except that if VISUAL *
- * or EDITOR contain the string "vi" then it will be linked to *
- * the "viins" keymap. */
+ * will be linked to the "emacs" keymap. */
linkkeymap(vmap, "viins", 0);
linkkeymap(emap, "emacs", 0);
linkkeymap(amap, "vicmd", 0);
linkkeymap(oppmap, "viopp", 0);
linkkeymap(vismap, "visual", 0);
linkkeymap(smap, ".safe", 1);
- if (((ed = zgetenv("VISUAL")) && strstr(ed, "vi")) ||
- ((ed = zgetenv("EDITOR")) && strstr(ed, "vi")))
- linkkeymap(vmap, "main", 0);
- else
- linkkeymap(emap, "main", 0);
+ linkkeymap(emap, "main", 0);
/* the .safe map cannot be modified or deleted */
smap->flags |= KM_IMMUTABLE;
]]]
next prev parent reply other threads:[~2022-09-02 8:56 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 4:31 [RFC PATCH 0/3] Improve defaults Felipe Contreras
2022-08-24 4:31 ` [RFC PATCH 1/3] Make SAVEHIST default to HISTSIZE Felipe Contreras
2022-08-24 4:31 ` [RFC PATCH 2/3] Increase default HISTSIZE to 1000 Felipe Contreras
2022-08-24 4:31 ` [RFC PATCH 3/3] FAQ: sync newuser-install Felipe Contreras
2022-08-24 9:06 ` Daniel Shahaf
2022-08-24 17:32 ` Felipe Contreras
2022-08-24 18:28 ` Eric Cook
2022-08-24 19:11 ` Felipe Contreras
2022-08-24 19:24 ` Matthew Martin
2022-08-24 19:25 ` Eric Cook
2022-08-24 19:40 ` Eric Cook
2022-08-24 20:03 ` Felipe Contreras
2022-08-24 20:11 ` Eric Cook
2022-08-24 20:27 ` Felipe Contreras
2022-08-24 20:53 ` Eric Cook
2022-08-25 8:04 ` Daniel Shahaf
2022-08-25 22:22 ` Bart Schaefer
2022-08-25 22:44 ` Felipe Contreras
2022-08-25 23:08 ` Bart Schaefer
2022-08-26 4:22 ` Felipe Contreras
2022-08-31 11:43 ` Vincent Lefevre
2022-08-26 5:20 ` Daniel Shahaf
2022-08-26 13:57 ` Mikael Magnusson
2022-08-26 14:04 ` Roman Perepelitsa
2022-08-26 23:43 ` Lawrence Velázquez
2022-08-27 15:17 ` Daniel Shahaf
2022-08-27 15:34 ` Roman Perepelitsa
2022-08-26 18:44 ` Felipe Contreras
2022-08-27 0:23 ` Mikael Magnusson
2022-08-27 0:31 ` Bart Schaefer
2022-08-27 3:18 ` Felipe Contreras
2022-08-27 3:52 ` Lawrence Velázquez
2022-08-27 15:44 ` Daniel Shahaf
2022-08-30 19:31 ` Felipe Contreras
2022-08-31 12:28 ` Vincent Lefevre
2022-08-31 19:36 ` Bart Schaefer
2022-09-01 0:23 ` Vincent Lefevre
2022-09-01 0:35 ` Bart Schaefer
2022-09-01 1:21 ` Vincent Lefevre
2022-09-01 2:42 ` [PATCH] initialization of main keymap Bart Schaefer
2022-09-01 21:58 ` Felipe Contreras
2022-09-01 22:34 ` Bart Schaefer
2022-09-01 22:54 ` Felipe Contreras
2022-09-02 8:51 ` Daniel Shahaf [this message]
2022-09-02 13:23 ` Vincent Lefevre
2022-09-02 13:42 ` Felipe Contreras
2022-09-04 9:39 ` Daniel Shahaf
2022-09-05 8:55 ` Vincent Lefevre
2022-09-02 13:32 ` Felipe Contreras
2022-09-02 16:48 ` Bart Schaefer
2022-09-04 9:35 ` Daniel Shahaf
2022-09-02 0:04 ` Vincent Lefevre
2022-09-02 5:06 ` Bart Schaefer
2022-09-02 13:15 ` Vincent Lefevre
2022-09-04 9:42 ` ${EDITOR} with spaces (was: Re: [PATCH] initialization of main keymap) Daniel Shahaf
2022-09-04 10:48 ` Mikael Magnusson
2022-09-05 9:15 ` Vincent Lefevre
2022-09-05 21:17 ` Lawrence Velázquez
2022-09-02 9:20 ` [RFC PATCH 3/3] FAQ: sync newuser-install Daniel Shahaf
2022-09-02 13:50 ` Vincent Lefevre
2022-08-31 21:57 ` Mikael Magnusson
2022-08-31 22:28 ` Roman Perepelitsa
2022-09-01 0:29 ` Bart Schaefer
2022-09-01 22:45 ` Felipe Contreras
2022-09-02 3:46 ` Mikael Magnusson
2022-09-02 5:57 ` Felipe Contreras
2022-09-02 23:14 ` Mikael Magnusson
2022-09-02 23:56 ` Felipe Contreras
2022-09-02 9:18 ` Daniel Shahaf
2022-09-02 12:50 ` Vincent Lefevre
2022-09-02 13:28 ` Felipe Contreras
2022-09-02 13:47 ` Vincent Lefevre
2022-09-02 13:54 ` Felipe Contreras
2022-09-03 13:38 ` Roman Perepelitsa
2022-09-03 19:07 ` Felipe Contreras
2022-09-03 19:27 ` Roman Perepelitsa
2022-09-03 20:08 ` Felipe Contreras
2022-09-03 20:23 ` Roman Perepelitsa
2022-09-03 20:49 ` Felipe Contreras
2022-09-03 23:12 ` Roman Perepelitsa
2022-09-03 18:59 ` Felipe Contreras
2022-09-04 0:08 ` Roman Perepelitsa
2022-09-03 19:24 ` Felipe Contreras
2022-08-27 0:35 ` Felipe Contreras
2022-08-27 2:24 ` Bart Schaefer
2022-08-27 15:40 ` Daniel Shahaf
2022-08-27 15:55 ` Bart Schaefer
2022-08-27 17:53 ` Daniel Shahaf
2022-08-24 20:58 ` [RFC PATCH 0/3] Improve defaults Bart Schaefer
2022-08-24 21:50 ` Felipe Contreras
2022-08-24 22:18 ` Bart Schaefer
2022-08-24 22:54 ` Felipe Contreras
2022-08-24 21:39 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902085110.GE5920@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=felipe.contreras@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).