Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend
@ 2022-10-14 17:28 nyanpasu64
  2022-10-14 21:05 ` paper42
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: nyanpasu64 @ 2022-10-14 17:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

There is a new pull request by nyanpasu64 against master on the void-packages repository

https://github.com/nyanpasu64/void-packages godot-update-pulse
https://github.com/void-linux/void-packages/pull/39957

godot: update to 3.5.1 and enable PulseAudio backend
Enabling Godot's PulseAudio driver fixes audio playback on PipeWire. Previously, the package's only enabled audio driver was ALSA, but Godot on alsa-pipewire stutters, and Godot on HW ALSA devices prevents PipeWire apps from playing audio.

#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - none, `./xbps-src -a armv6l pkg godot` claims godot can't cross-compile and I didn't try native building

Fixes #39936.

A patch file from https://github.com/void-linux/void-packages/pull/39957.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-update-pulse-39957.patch --]
[-- Type: text/x-diff, Size: 2832 bytes --]

From e3271e86c7a83675f13387e2535576c0e936c34e Mon Sep 17 00:00:00 2001
From: nyanpasu64 <nyanpasu64@tuta.io>
Date: Fri, 14 Oct 2022 05:30:24 -0700
Subject: [PATCH 1/2] godot: enable PulseAudio backend

Enabling Godot's PulseAudio driver fixes audio playback on PipeWire.
Previously, the package's only enabled audio driver was ALSA, but Godot
on alsa-pipewire stutters, and Godot on HW ALSA devices prevents
PipeWire apps from playing audio.
---
 srcpkgs/godot/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index 67f591a4924b..43c6619f0995 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -10,7 +10,7 @@ build_style=scons
 # Use builtin bullet for now as it's too old in repos (needs 2.89)
 # Toggle to not use builtin once bullet has been updated
 make_build_args="platform=x11 tools=yes target=release_debug dev=no progress=no
- pulseaudio=no builtin_bullet=false builtin_libpng=false builtin_libvpx=false
+ builtin_bullet=false builtin_libpng=false builtin_libvpx=false
  builtin_libwebp=false builtin_libogg=false builtin_libtheora=false
  builtin_opus=false builtin_libvorbis=false builtin_enet=false
  builtin_zlib=false builtin_freetype=false builtin_mbedtls=false
@@ -21,7 +21,7 @@ makedepends="
  libXinerama-devel libXrender-devel libXrandr-devel libX11-devel
  bullet-devel libpng-devel libvpx-devel libwebp-devel libogg-devel libtheora-devel
  opus-devel opusfile-devel libvorbis-devel libenet-devel zlib-devel mbedtls-devel
- miniupnpc-devel pcre2-devel"
+ miniupnpc-devel pcre2-devel pulseaudio-devel"
 short_desc="Multiplatform 2D and 3D engine"
 maintainer="Nick Hahn <nick.hahn@hotmail.de>"
 license="MIT"

From 3117970bb33691fdecbb786fa77aa31d9cb70b6f Mon Sep 17 00:00:00 2001
From: nyanpasu64 <nyanpasu64@tuta.io>
Date: Fri, 14 Oct 2022 06:02:23 -0700
Subject: [PATCH 2/2] godot: update to 3.5.1.

---
 srcpkgs/godot/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index 43c6619f0995..82309ba0d234 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,6 +1,6 @@
 # Template file for 'godot'
 pkgname=godot
-version=3.5
+version=3.5.1
 revision=1
 archs="x86_64* i686* aarch64* armv7* ppc64*"
 wrksrc="${pkgname}-${version}-stable"
@@ -27,7 +27,7 @@ maintainer="Nick Hahn <nick.hahn@hotmail.de>"
 license="MIT"
 homepage="https://www.godotengine.org/"
 distfiles="https://github.com/godotengine/${pkgname}/archive/${version}-stable.tar.gz"
-checksum=c65425e1d56a7097990f231c27c9271b7159f763dc59f0eaba9273633e59da36
+checksum=164523c1c8aef0b69b135645794f5bece3f63788556a56aa293c118cde457023
 nocross=https://build.voidlinux.org/builders/armv7l_builder/builds/6342/steps/shell_3/logs/stdio
 
 CFLAGS+=" -fPIE -fPIC"

^ permalink raw reply	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-11-13 15:54 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
2022-10-14 21:05 ` paper42
2022-10-14 21:06 ` [PR REVIEW] " paper42
2022-10-14 21:07 ` paper42
2022-10-14 21:23 ` nyanpasu64
2022-10-14 21:42 ` paper42
2022-10-14 21:47 ` paper42
2022-10-14 21:49 ` nyanpasu64
2022-10-14 22:08 ` paper42
2022-10-14 22:11 ` [PR PATCH] [Updated] " nyanpasu64
2022-10-15  6:53 ` nyanpasu64
2022-11-06 20:14 ` nyanpasu64
2022-11-10 19:41 ` paper42
2022-11-13 14:20 ` [PR PATCH] [Updated] " nyanpasu64
2022-11-13 15:54 ` [PR PATCH] [Merged]: " Johnnynator

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).